Skip to content

fix: Enable delete key for deleting... #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoxbro merged 1 commit into from
Jun 3, 2026
Merged

fix: Enable delete key for deleting... #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/panel_reactflow/models/reactflow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ function FlowInner({
nodesDraggable={editable}
nodesConnectable={editable && enableConnect}
elementsSelectable={editable}
deleteKeyCode={enableDelete ? "Backspace" : null}
deleteKeyCode={enableDelete ? ["Backspace", "Delete"] : null}
multiSelectionKeyCode={enableMultiselect ? "Shift" : null}
fitView
>
Expand Down
24 changes: 24 additions & 0 deletions tests/ui/test_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,30 @@ def test_delete_node_reindexes_views(page):
expect(_node_locator(page, "Node B").filter(has_text="View B")).to_have_count(1)


@pytest.mark.parametrize("key", ["Backspace", "Delete"])
def test_deletes_node(page, key):
flow = _make_flow()
serve_component(page, flow)

_node_locator(page, "Start").click(force=True)
page.keyboard.press(key)

wait_until(lambda: all(node["id"] != "n1" for node in flow.nodes), timeout=8000)
expect(_node_locator(page, "Start")).to_have_count(0)


@pytest.mark.parametrize("key", ["Backspace", "Delete"])
def test_deletes_edge(page, key):
flow = _make_flow()
serve_component(page, flow)

page.locator(".react-flow__edge-path").first.click(force=True)
page.keyboard.press(key)

wait_until(lambda: len(flow.edges) == 0, timeout=8000)
expect(page.locator(".react-flow__edge")).to_have_count(0)


def test_python_remove_node_reindexes_views(page):
nodes = [
NodeSpec(
Expand Down
Loading