-
-
Notifications
You must be signed in to change notification settings - Fork 158
Change runner version to ubuntu-22.04 in release.yml #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the runner version for multiple jobs in the release workflow to ubuntu-22.04. Signed-off-by: Nitish Tiwari <nitish@parseable.com>
WalkthroughUpdated three GitHub Actions runner specifications in the release workflow from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/release.yml (2)
325-325: Consistent pinning across Linux jobs.Good consistency with the other Linux build jobs. Note that Windows and macOS jobs still use
-latestrunners. Consider whether those should also be pinned for complete reproducibility, or document if the current mixed approach is intentional.
23-23: Consider documenting the runner version pinning strategy.This PR pins Linux runners to ubuntu-22.04 while leaving Windows and macOS on
-latest. Consider:
- Documenting the rationale: Add a comment explaining why Linux is pinned (e.g., stability requirements, dependency concerns) while other platforms float
- Maintenance plan: Ubuntu 22.04 LTS support ends in April 2027. Set up a reminder to evaluate migration to ubuntu-24.04 or later versions
- Monitoring: Watch for security advisories or deprecation notices from GitHub Actions regarding ubuntu-22.04
- Testing: Consider testing against ubuntu-24.04 periodically to prepare for future migration
Also applies to: 175-175, 325-325
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: nikhilsinhaparseable
Repo: parseablehq/parseable PR: 1302
File: .github/workflows/build.yaml:170-175
Timestamp: 2025-04-26T03:58:02.341Z
Learning: In the parseable project, the Linux-specific environment variables (PKG_CONFIG_PATH, SASL2_DIR, OPENSSL_DIR, OPENSSL_ROOT_DIR, SASL2_STATIC) in the Kafka build step of GitHub Actions workflows don't cause issues for macOS builds and can safely be applied to both platforms.
📚 Learning: 2025-04-26T03:58:02.341Z
Learnt from: nikhilsinhaparseable
Repo: parseablehq/parseable PR: 1302
File: .github/workflows/build.yaml:170-175
Timestamp: 2025-04-26T03:58:02.341Z
Learning: In the parseable project, the Linux-specific environment variables (PKG_CONFIG_PATH, SASL2_DIR, OPENSSL_DIR, OPENSSL_ROOT_DIR, SASL2_STATIC) in the Kafka build step of GitHub Actions workflows don't cause issues for macOS builds and can safely be applied to both platforms.
Applied to files:
.github/workflows/release.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: coverage
🔇 Additional comments (2)
.github/workflows/release.yml (2)
175-175: Version pinning is especially valuable here given the complex dependencies.The Kafka build job has numerous system dependencies (gcc-11, g++-11, cmake, zlib, zstd, lz4, openssl) that could vary across Ubuntu versions. Pinning to ubuntu-22.04 ensures these dependencies remain consistent and available.
23-23: Good choice to pin to Ubuntu 22.04 LTS for reproducibility.Pinning the runner to a specific Ubuntu LTS version improves build reproducibility and prevents unexpected breakages when
ubuntu-latestis updated. Ubuntu 22.04 LTS is actively supported by GitHub Actions with recent image releases and is appropriate for stable release builds.
Updated the runner version for multiple jobs in the release workflow to ubuntu-22.04.
This is need to ensure runtime dependencies like glibc are not broken at runtime when
the binary is run on a new machine.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.