Skip to content

Replace rand() with random_bytes() for SQL placeholder generation #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flightlesstux wants to merge 1 commit into from
+2 −2
Closed

Replace rand() with random_bytes() for SQL placeholder generation #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Model/Traits/Query/CaseSensitiveCompareValueTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function getCaseSensitiveValue(SelectQuery $query, mixed $col): QueryExpr
return $col;
}

$valuePlaceholder = ':value_case_insensitive_' . rand();
$valuePlaceholder = ':value_case_insensitive_' . bin2hex(random_bytes(4));
$query = $query->bind($valuePlaceholder, $col, $this->getBindType($col));

return $query->newExpr()->add("CONVERT({$valuePlaceholder} using utf8mb4) COLLATE utf8mb4_bin");
Expand All @@ -65,7 +65,7 @@ public function getCaseSensitiveValues(SelectQuery $query, array $values): array
$conditions = [];
$values = array_unique($values);
foreach ($values as $value) {
$valuePlaceholder = ':value_case_insensitive_' . rand();
$valuePlaceholder = ':value_case_insensitive_' . bin2hex(random_bytes(4));
$conditions[] = $query
->newExpr()
->add("CONVERT({$valuePlaceholder} using utf8mb4) COLLATE utf8mb4_bin");
Expand Down