Add layer tests based on deptrac layers.#832
Draft
DanielBadura wants to merge 1 commit into3.19.xfrom
Draft
Conversation
This is the next step into removing deptrac in favor of phpat
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the next step into removing deptrac in favor of phpat.
These 3 violations, which are in the deptrace baseline, are not covered right now:
These 2 are false positives from deptrac imho:
As the
AggregateRootIdinterface as a dependency on the attributePatchlevel\EventSourcing\Serializer\Normalizer\IdNormalizerand not the concrete classes. So this is a good that these 2 are not picked up.Is due the dependecy is coming from a union type inside the phpdoc. As soon as I change
/** @param string|class-string<AggregateRoot> $name */to/** @param class-string<AggregateRoot> $name */it gets picked up correctly:So this is a bug on phpat side.
With this change, we can remove deptrac as an dependency and still have our layers protected. WDYT @DavidBadura ?