Conversation
…ression
React 18 calls console.error with a format string and separate arguments
(e.g. console.error('Invalid prop `%s` supplied to `%s`', 'data-ds',
'React.Fragment')), so checking only arguments[0] missed the match.
Join all arguments before checking for 'data-ds' and 'React.Fragment'.
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run domscribe-test-fixtures:integration--web... |
✅ Succeeded | 1m 48s | View ↗ |
nx run domscribe-test-fixtures:integration--web... |
✅ Succeeded | 1m 49s | View ↗ |
nx run domscribe-test-fixtures:integration--web... |
✅ Succeeded | 1m 42s | View ↗ |
nx run domscribe-test-fixtures:integration--web... |
✅ Succeeded | 1m 42s | View ↗ |
nx run domscribe-test-fixtures:install-fixture-... |
✅ Succeeded | 51s | View ↗ |
nx run domscribe-test-fixtures:install-fixture-... |
✅ Succeeded | 43s | View ↗ |
nx run domscribe-test-fixtures:integration--vit... |
✅ Succeeded | 31s | View ↗ |
nx run domscribe-test-fixtures:integration--vit... |
✅ Succeeded | 32s | View ↗ |
Additional runs (18) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-03-19 13:18:02 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.errorwith a format string and separate arguments:console.error('Invalid prop \%s` supplied to `%s`', 'data-ds', 'React.Fragment'). The previous suppression only checkedarguments[0](the format string), which contains%s` placeholders — not the actual prop name or component name — so the filter never matched.data-dsandReact.Fragment. Works for both React 18 (format string + args) and React 19 (pre-formatted string).Test plan
data-dswarnings no longer appear🤖 Generated with Claude Code