fix(pfe-tools): use WDS plugin for TS redirect instead of koa middleware#3144
Open
bennypowers wants to merge 2 commits into
Open
fix(pfe-tools): use WDS plugin for TS redirect instead of koa middleware#3144bennypowers wants to merge 2 commits into
bennypowers wants to merge 2 commits into
Conversation
The liveReloadTsChangesMiddleware ran as koa middleware, which executes AFTER WDS static file serving (koa-send). When a .js file didn't exist on disk, koa-send returned 404 before the middleware could redirect to the .ts source. Convert to a WDS plugin with a serve hook, which runs BEFORE static file resolution. This fixes 404 errors for elements that only have .ts source files (no pre-compiled .js). Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(pfe-tools): use WDS plugin for TS redirect instead of koa middleware"
} |
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
The previous approach (serve hook) broke esbuild compilation because returning from serve() prevents other plugins from running. Instead, keep the koa middleware but call next() first, then redirect to .ts only when the .js file doesn't exist (404). This is backwards compatible: when compiled .js exists, it serves normally. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PFE dev-server request handling to improve TypeScript-source resolution when .js files are requested but only .ts sources exist in the repo, reducing 404s during local development and test runs.
Changes:
- Adjusts
liveReloadTsChangesMiddlewareto run after downstream middleware and only redirect when the response is a 404. - Removes the inline comment describing the previous regex capture-group behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
91
to
97
| const TYPESCRIPT_SOURCES_RE = new RegExp(`(${config.elementsDir}|pfe-core)/.*\\.js`); | ||
|
|
||
| return function(ctx, next) { | ||
| if (!ctx.path.includes('node_modules') && ctx.path | ||
| .match(TYPESCRIPT_SOURCES_RE)) { | ||
| return async function(ctx, next) { | ||
| await next(); | ||
| if (ctx.status === 404 | ||
| && !ctx.path.includes('node_modules') | ||
| && TYPESCRIPT_SOURCES_RE.test(ctx.path)) { | ||
| ctx.redirect(ctx.path.replace('.js', '.ts')); |
Comment on lines
+92
to
98
| return async function(ctx, next) { | ||
| await next(); | ||
| if (ctx.status === 404 | ||
| && !ctx.path.includes('node_modules') | ||
| && TYPESCRIPT_SOURCES_RE.test(ctx.path)) { | ||
| ctx.redirect(ctx.path.replace('.js', '.ts')); | ||
| } else { | ||
| return next(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
liveReloadTsChangesMiddlewarefrom koa middleware to a WDSservehook pluginkoa-send(static file serving), so when a.jsfile didn't exist on disk,koa-sendreturned 404 before the middleware could rewrite the path to.tsservehook, the path rewrite runs BEFORE static file resolution.tssource files (no pre-compiled.js), such aspf-v6-tooltipTest plan
npx wtr elements/pf-v5-clipboard-copy/test/pf-clipboard-copy.spec.tspasses with no compiled.jsin elements/pf-v6-tooltipor other elements