Skip to content

fix(DescriptionList): use correct token for termWidth #12253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolethoen wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −6
Open

fix(DescriptionList): use correct token for termWidth #12253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/react-core/src/components/DescriptionList/DescriptionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,9 @@ import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/DescriptionList/description-list';
import { formatBreakpointMods } from '../../helpers';
import cssGridTemplateColumnsMin from '@patternfly/react-tokens/dist/esm/c_description_list_GridTemplateColumns_min';
// import cssTermWidth from '@patternfly/react-tokens/dist/esm/c_description_list__term_width';
import cssTermWidth from '@patternfly/react-tokens/dist/esm/c_description_list__term_width';
import cssHorizontalTermWidth from '@patternfly/react-tokens/dist/esm/c_description_list_m_horizontal__term_width';

const cssTermWidth = {
name: `--${styles.descriptionList}_term-width`
};

export interface BreakpointModifiers {
default?: string;
md?: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DescriptionList/__tests__/DescriptionList.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ test(`Renders style when isHorizontal and horizontalTermWidthModifier is set`, (
expect(screen.getByLabelText('list')).toHaveStyle(listStyles);
});

test.skip(`Renders style when termWidth is set`, () => {
test(`Renders style when termWidth is set`, () => {
render(<DescriptionList aria-label="list" isHorizontal termWidth="30px" />);
const listStyles = {};
listStyles[`--${styles.descriptionList}__term--width`] = '30px';
Expand Down
Loading