fix(InfrastructureIcons): replaced with RH brand icons part 3#12503
Open
thatblindgeye wants to merge 5 commits into
Open
fix(InfrastructureIcons): replaced with RH brand icons part 3#12503thatblindgeye wants to merge 5 commits into
thatblindgeye wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (16)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (9)
🚧 Files skipped from review as they are similar to previous changes (6)
WalkthroughLegacy PatternFly folder, file, and image icons are replaced with RhUI fill icon equivalents across MultipleFileUpload, Nav, TreeView, and Table examples, demos, docs, and tests. ChangesRhUI Icon Migration
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12503.surge.sh A11y report: https://pf-react-pr-12503-a11y.surge.sh |
rebeccaalpert
left a comment
rebeccaalpert
left a comment
Member
There was a problem hiding this comment.
Looks good - just one question about a maybe-orphan import.
| import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon'; | ||
| import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon'; | ||
| import FolderIcon from '@patternfly/react-icons/dist/esm/icons/folder-icon'; | ||
| import RhUiFolderFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-folder-fill-icon'; |
Contributor
Author
There was a problem hiding this comment.
Nothing to see here 🙈
thatblindgeye
force-pushed
the
iss12399_part3
branch
from
2f78608 to
16ccbe6
Compare
rebeccaalpert
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Towards #12399
Covers FileIcon, FileImageIcon, FolderIcon, and FolderOpenIcon
Additional issues:
Summary by CodeRabbit
Release Notes
Style
Documentation & Examples
Tests