Skip to content

fix(HelpIcon): Replace HelpIcon with RhUiQuestionMarkCircleIcon#12507

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-help-icon-with-rh-ui-question-mark-circle
Open

fix(HelpIcon): Replace HelpIcon with RhUiQuestionMarkCircleIcon#12507
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-help-icon-with-rh-ui-question-mark-circle

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

Release Notes

  • Style
    • Updated help icon visuals across components, demos, and documentation by replacing the previous help icon with a question mark circle icon for improved consistency.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21bb96f7-e0d7-4783-95d4-c07ae2d7e51e

📥 Commits

Reviewing files that changed from the base of the PR and between 6a5bca3 and b69b6a0.

📒 Files selected for processing (33)
  • packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
  • packages/react-core/src/components/Form/FormGroupLabelHelp.tsx
  • packages/react-core/src/components/Form/examples/Form.md
  • packages/react-core/src/components/Modal/examples/Modal.md
  • packages/react-core/src/components/Modal/examples/ModalWithHelp.tsx
  • packages/react-core/src/components/Tabs/examples/Tabs.md
  • packages/react-core/src/components/Tabs/examples/TabsHelp.tsx
  • packages/react-core/src/components/Tabs/examples/TabsHelpAndClose.tsx
  • packages/react-core/src/demos/DashboardHeader.tsx
  • packages/react-core/src/demos/Masthead.md
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md
  • packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx
  • packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx
  • packages/react-core/src/demos/Page.md
  • packages/react-core/src/demos/PasswordStrength.md
  • packages/react-core/src/demos/RTL/RTL.md
  • packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx
  • packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx
  • packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
  • packages/react-core/src/demos/examples/Nav/NavFlyout.tsx
  • packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx
  • packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx
  • packages/react-core/src/demos/examples/Nav/NavManual.tsx
  • packages/react-core/src/demos/examples/Page/PageContextSelector.tsx
  • packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx
  • packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx
  • packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx
  • packages/react-core/src/deprecated/components/Modal/examples/Modal.md
  • packages/react-core/src/deprecated/components/Modal/examples/ModalWithHelp.tsx
  • packages/react-table/src/components/Table/HeaderCellInfoWrapper.tsx
  • packages/react-table/src/demos/DashboardHeader.tsx
  • packages/react-table/src/demos/Table.md
✅ Files skipped from review due to trivial changes (27)
  • packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx
  • packages/react-core/src/components/Tabs/examples/TabsHelp.tsx
  • packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx
  • packages/react-core/src/demos/Page.md
  • packages/react-core/src/demos/Masthead.md
  • packages/react-core/src/components/Tabs/examples/TabsHelpAndClose.tsx
  • packages/react-core/src/demos/PasswordStrength.md
  • packages/react-core/src/deprecated/components/Modal/examples/ModalWithHelp.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-core/src/deprecated/components/Modal/examples/Modal.md
  • packages/react-core/src/components/Form/FormGroupLabelHelp.tsx
  • packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx
  • packages/react-core/src/demos/RTL/RTL.md
  • packages/react-table/src/components/Table/HeaderCellInfoWrapper.tsx
  • packages/react-core/src/demos/examples/Page/PageContextSelector.tsx
  • packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
  • packages/react-table/src/demos/DashboardHeader.tsx
  • packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx
  • packages/react-core/src/components/Form/examples/Form.md
  • packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md
  • packages/react-core/src/demos/examples/Nav/NavFlyout.tsx
  • packages/react-core/src/components/Tabs/examples/Tabs.md
  • packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx
  • packages/react-core/src/demos/DashboardHeader.tsx
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx
  • packages/react-core/src/demos/examples/Nav/NavManual.tsx
🚧 Files skipped from review as they are similar to previous changes (6)
  • packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx
  • packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
  • packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx
  • packages/react-core/src/components/Modal/examples/ModalWithHelp.tsx
  • packages/react-core/src/components/Modal/examples/Modal.md
  • packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx

Walkthrough

This change replaces HelpIcon with RhUiQuestionMarkCircleIcon in production components, examples, and demos across react-code-editor, react-core, and react-table.

Changes

HelpIcon → RhUiQuestionMarkCircleIcon Migration

Layer / File(s) Summary
Core component icon updates
packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx, packages/react-core/src/components/Form/FormGroupLabelHelp.tsx, packages/react-table/src/components/Table/HeaderCellInfoWrapper.tsx
Production components update the imported icon and rendered icon props to use RhUiQuestionMarkCircleIcon instead of HelpIcon, including tooltip and popover button branches in the table header wrapper.
Component example icon updates
packages/react-core/src/components/Form/examples/Form.md, packages/react-core/src/components/Modal/examples/*, packages/react-core/src/deprecated/components/Modal/examples/*, packages/react-core/src/components/Tabs/examples/*
Form, Modal, Tabs, and deprecated Modal example files and their markdown references replace HelpIcon imports and rendered icons with RhUiQuestionMarkCircleIcon.
Demo icon updates
packages/react-core/src/demos/..., packages/react-table/src/demos/...
Demo TSX files and markdown docs in react-core and react-table replace help-related icon imports and dropdown item icons with RhUiQuestionMarkCircleIcon.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

Needs design review

Suggested reviewers

  • thatblindgeye
  • nicolethoen
  • kmcfaul
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: replacing HelpIcon with RhUiQuestionMarkCircleIcon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:15
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-help-icon-with-rh-ui-question-mark-circle branch from 2cf1b6a to 6a5bca3 Compare June 24, 2026 13:53
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-help-icon-with-rh-ui-question-mark-circle branch from 6a5bca3 to b69b6a0 Compare June 24, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants