Skip to content

fix(SyncIcon): Replace SyncIcon with RhUiSyncIcon#12512

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-sync-icon-with-rh-ui-sync
Open

fix(SyncIcon): Replace SyncIcon with RhUiSyncIcon#12512
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-sync-icon-with-rh-ui-sync

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated sync icon components used across toolbar and table examples.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ce7d7630-3ef9-4933-85d1-e5d61a15e730

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and 118af99.

📒 Files selected for processing (7)
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarGroups.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-table/src/demos/examples/TableSortableResponsive.tsx

Walkthrough

Across six files in react-core, react-table, and react-integration packages, all SyncIcon imports and usages in toolbar example and demo components are replaced with RhUiSyncIcon. No component logic, structure, or behavior is changed.

Changes

SyncIcon → RhUiSyncIcon in Toolbar Examples and Demos

Layer / File(s) Summary
Icon swap across all toolbar examples and demos
packages/react-core/src/components/Toolbar/examples/Toolbar.md, packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx, packages/react-core/src/components/Toolbar/examples/ToolbarGroups.tsx, packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx, packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx, packages/react-table/src/demos/Table.md, packages/react-table/src/demos/examples/TableSortableResponsive.tsx
Each file replaces the SyncIcon import with RhUiSyncIcon and updates the toolbar sync button's icon prop accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing SyncIcon with RhUiSyncIcon across multiple files in the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants