Skip to content

fix(TimesCircleIcon): Replace TimesCircleIcon with RhUiCloseCircleFillIcon #12513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(TimesCircleIcon): Replace TimesCircleIcon with RhUiCloseCircleFillIcon #12513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ExpandableSection } from '../ExpandableSection';
import { useSSRSafeId } from '../../helpers';
import RhUiInProgressIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-in-progress-icon';
import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-check-circle-fill-icon';
import TimesCircleIcon from '@patternfly/react-icons/dist/esm/icons/times-circle-icon';
import RhUiCloseCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-close-circle-fill-icon';

/** Acts as an expandable container for all uploaded file statuses.
* An optional text and/or icon can also be passed into this sub-component.
Expand Down Expand Up @@ -41,7 +41,7 @@ export const MultipleFileUploadStatus: React.FunctionComponent<MultipleFileUploa
useEffect(() => {
switch (statusToggleIcon) {
case 'danger':
setIcon(<TimesCircleIcon />);
setIcon(<RhUiCloseCircleFillIcon />);
break;
case 'success':
setIcon(<RhUiCheckCircleFillIcon />);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/PrimaryDetail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-u
import RhUiWarningFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warning-fill-icon';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import TimesCircleIcon from '@patternfly/react-icons/dist/esm/icons/times-circle-icon';
import RhUiCloseCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-close-circle-fill-icon';
import pfIcon from './assets/pf-logo-small.svg';
import activeMQIcon from './assets/activemq-core_200x150.png';
import avroIcon from './assets/camel-avro_200x150.png';
Expand Down
6 changes: 3 additions & 3 deletions packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-u
import RhUiWarningFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warning-fill-icon';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import TimesCircleIcon from '@patternfly/react-icons/dist/esm/icons/times-circle-icon';
import RhUiCloseCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-close-circle-fill-icon';

interface SelectOptionType extends Omit<SelectOptionProps, 'children'> {
label: string;
Expand Down Expand Up @@ -289,7 +289,7 @@ export const PrimaryDetailContentPadding: React.FunctionComponent = () => {
<RhUiWarningFillIcon /> 5
</FlexItem>
<FlexItem>
<TimesCircleIcon /> 5
<RhUiCloseCircleFillIcon /> 5
</FlexItem>
<FlexItem>Updated 2 days ago</FlexItem>
</Flex>
Expand Down Expand Up @@ -386,7 +386,7 @@ export const PrimaryDetailContentPadding: React.FunctionComponent = () => {
<RhUiWarningFillIcon /> 5
</FlexItem>
<FlexItem>
<TimesCircleIcon /> 5
<RhUiCloseCircleFillIcon /> 5
</FlexItem>
<FlexItem>Updated 2 days ago</FlexItem>
</Flex>
Expand Down
6 changes: 3 additions & 3 deletions packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-u
import RhUiWarningFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warning-fill-icon';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import TimesCircleIcon from '@patternfly/react-icons/dist/esm/icons/times-circle-icon';
import RhUiCloseCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-close-circle-fill-icon';

interface SelectOptionType extends Omit<SelectOptionProps, 'children'> {
label: string;
Expand Down Expand Up @@ -289,7 +289,7 @@ export const PrimaryDetailFullPage: React.FunctionComponent = () => {
<RhUiWarningFillIcon /> 5
</FlexItem>
<FlexItem>
<TimesCircleIcon /> 5
<RhUiCloseCircleFillIcon /> 5
</FlexItem>
<FlexItem>Updated 2 days ago</FlexItem>
</Flex>
Expand Down Expand Up @@ -386,7 +386,7 @@ export const PrimaryDetailFullPage: React.FunctionComponent = () => {
<RhUiWarningFillIcon /> 5
</FlexItem>
<FlexItem>
<TimesCircleIcon /> 5
<RhUiCloseCircleFillIcon /> 5
</FlexItem>
<FlexItem>Updated 2 days ago</FlexItem>
</Flex>
Expand Down
6 changes: 3 additions & 3 deletions packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-u
import RhUiWarningFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warning-fill-icon';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import TimesCircleIcon from '@patternfly/react-icons/dist/esm/icons/times-circle-icon';
import RhUiCloseCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-close-circle-fill-icon';

interface SelectOptionType extends Omit<SelectOptionProps, 'children'> {
label: string;
Expand Down Expand Up @@ -289,7 +289,7 @@ export const PrimaryDetailInlineModifier: React.FunctionComponent = () => {
<RhUiWarningFillIcon /> 5
</FlexItem>
<FlexItem>
<TimesCircleIcon /> 5
<RhUiCloseCircleFillIcon /> 5
</FlexItem>
<FlexItem>Updated 2 days ago</FlexItem>
</Flex>
Expand Down Expand Up @@ -386,7 +386,7 @@ export const PrimaryDetailInlineModifier: React.FunctionComponent = () => {
<RhUiWarningFillIcon /> 5
</FlexItem>
<FlexItem>
<TimesCircleIcon /> 5
<RhUiCloseCircleFillIcon /> 5
</FlexItem>
<FlexItem>Updated 2 days ago</FlexItem>
</Flex>
Expand Down
Loading