Skip to content

fix(LongArrowAltDown/UpIcon): Replace with microns versions#12517

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-long-arrow-alt-down-icon-with-rh-microns-arrow-down
Open

fix(LongArrowAltDown/UpIcon): Replace with microns versions#12517
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-long-arrow-alt-down-icon-with-rh-microns-arrow-down

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review. I know this one is tiny but others are large.

Additional issues:

Summary by CodeRabbit

Style

  • Updated the down-arrow and up-arrow icons used in table sorting to a refreshed “RhMicrons” arrow set.
  • Updated Icon component examples to use the matching “RhMicrons” down-arrow icon.

Documentation

  • Refreshed the Icon examples documentation to reflect the new “RhMicrons” arrow icon import.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Replaces LongArrowAltDownIcon and LongArrowAltUpIcon with RhMicronsArrowDownIcon and RhMicronsArrowUpIcon across the IconBasic example, its markdown documentation, and the SortColumn table component's sort-direction indicators.

Changes

Icon Replacement

Layer / File(s) Summary
IconBasic example and docs
packages/react-core/src/components/Icon/examples/Icon.md, packages/react-core/src/components/Icon/examples/IconBasic.tsx
Swaps the import and rendered usage of the down-arrow icon from LongArrowAltDownIcon to RhMicronsArrowDownIcon in both the example component and its markdown documentation.
SortColumn arrow icons
packages/react-table/src/components/Table/SortColumn.tsx
Replaces LongArrowAltUpIcon and LongArrowAltDownIcon imports with RhMicronsArrowUpIcon and RhMicronsArrowDownIcon, and updates the SortedByIcon assignment to render the RhMicrons icons based on sort direction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The PR title directly reflects the main change: replacing LongArrowAltDown/UpIcon with their microns versions across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Cursor <cursoragent@cursor.com>

add
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-long-arrow-alt-down-icon-with-rh-microns-arrow-down branch from a50f129 to 2d07bec Compare June 23, 2026 22:04
@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert changed the title fix(LongArrowAltDownIcon): Replace LongArrowAltDownIcon with RhMicronsArrowDownIcon fix(LongArrowAltDown/UpIcon): Replace with microns versions Jun 23, 2026

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention, the icon used in this PR is much easier to see than the RhUiLongArrow icons. I tried those locally and could barely tell it was an arrow up or down.

@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants