Skip to content

fix(CheckIcon): Replace CheckIcon with RhMicronsCheckmarkIcon#12518

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-check-icon-with-rh-microns-checkmark
Open

fix(CheckIcon): Replace CheckIcon with RhMicronsCheckmarkIcon#12518
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-check-icon-with-rh-microns-checkmark

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

Release Notes

  • Style
    • Updated checkmark icons across UI components to use a new, consistent icon variant for improved visual design.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5491bb40-926c-43a4-b0a3-037ba0d993de

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and 95c0083.

⛔ Files ignored due to path filters (3)
  • packages/react-core/src/components/Icon/__tests__/__snapshots__/Icon.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/components/Switch/__tests__/__snapshots__/Switch.test.tsx.snap is excluded by !**/*.snap
  • packages/react-table/src/deprecated/components/Table/__tests__/__snapshots__/Table.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (13)
  • packages/react-core/src/components/ActionList/examples/ActionList.md
  • packages/react-core/src/components/ActionList/examples/ActionListVertical.tsx
  • packages/react-core/src/components/ActionList/examples/ActionListWithIcons.tsx
  • packages/react-core/src/components/HelperText/examples/HelperText.md
  • packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx
  • packages/react-core/src/components/Icon/__tests__/Icon.test.tsx
  • packages/react-core/src/components/Menu/MenuItem.tsx
  • packages/react-core/src/components/Switch/Switch.tsx
  • packages/react-core/src/demos/HelperText.md
  • packages/react-table/src/components/Table/EditColumn.tsx
  • packages/react-table/src/components/Table/examples/Table.md
  • packages/react-table/src/components/Table/examples/TableEditable.tsx
  • packages/react-table/src/demos/Table.md
💤 Files with no reviewable changes (2)
  • packages/react-core/src/demos/HelperText.md
  • packages/react-table/src/demos/Table.md

Walkthrough

All usages of CheckIcon across react-core and react-table packages are replaced with RhMicronsCheckmarkIcon. This affects production components (Switch, MenuItem, EditColumn), unit tests (Icon.test.tsx), component examples (ActionList, ActionListVertical, ActionListWithIcons, HelperTextWithCustomIcon, TableEditable), and documentation/demo Markdown files.

Changes

CheckIcon → RhMicronsCheckmarkIcon Migration

Layer / File(s) Summary
Production component icon swap
packages/react-core/src/components/Switch/Switch.tsx, packages/react-core/src/components/Menu/MenuItem.tsx, packages/react-table/src/components/Table/EditColumn.tsx
Switch replaces CheckIcon with RhMicronsCheckmarkIcon in both label and no-label render paths. MenuItem updates the selected-state icon. EditColumn updates the save button icon.
Icon component test updates
packages/react-core/src/components/Icon/__tests__/Icon.test.tsx
All test cases (render, class/size modifiers, status, inline, in-progress, and progress icon snapshot) swap CheckIcon for RhMicronsCheckmarkIcon as the child icon.
Examples and documentation
packages/react-core/src/components/ActionList/examples/ActionList.md, packages/react-core/src/components/ActionList/examples/ActionListVertical.tsx, packages/react-core/src/components/ActionList/examples/ActionListWithIcons.tsx, packages/react-core/src/components/HelperText/examples/HelperText.md, packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx, packages/react-core/src/demos/HelperText.md, packages/react-table/src/components/Table/examples/Table.md, packages/react-table/src/components/Table/examples/TableEditable.tsx, packages/react-table/src/demos/Table.md
All example .tsx files replace CheckIcon imports and JSX usages with RhMicronsCheckmarkIcon. Markdown doc files update their embedded import snippets or remove the now-unused CheckIcon import.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • thatblindgeye
  • nicolethoen
  • kmcfaul
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main objective of the changeset: replacing CheckIcon with RhMicronsCheckmarkIcon across multiple files and components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-check-icon-with-rh-microns-checkmark branch from 00e8f64 to 95c0083 Compare June 23, 2026 22:16
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 23, 2026 22:16
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants