Skip to content

fix(MinusIcon): Replace MinusIcon with RhUiMinusIcon#12522

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-minus-icon-with-rh-ui-minus
Open

fix(MinusIcon): Replace MinusIcon with RhUiMinusIcon#12522
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-minus-icon-with-rh-ui-minus

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Refactor
    • Updated icon implementations across multiple components and examples for consistency.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e3d3a010-1c0f-49b3-b36f-43155ad946ca

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and 1bedb7f.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (5)
  • packages/react-core/src/components/HelperText/HelperTextItem.tsx
  • packages/react-core/src/components/NumberInput/NumberInput.tsx
  • packages/react-core/src/components/Slider/examples/Slider.md
  • packages/react-core/src/components/Slider/examples/SliderActions.tsx
  • packages/react-core/src/demos/HelperText.md
💤 Files with no reviewable changes (1)
  • packages/react-core/src/demos/HelperText.md

Walkthrough

MinusIcon is replaced with RhUiMinusIcon in HelperTextItem, NumberInput, SliderActions, and the Slider and HelperText demo/example files. The HelperText.md demo additionally drops the now-unused MinusIcon import and adds useEffect/useState imports.

Changes

MinusIcon → RhUiMinusIcon Icon Replacement

Layer / File(s) Summary
Icon swap in components and examples
packages/react-core/src/components/HelperText/HelperTextItem.tsx, packages/react-core/src/components/NumberInput/NumberInput.tsx, packages/react-core/src/components/Slider/examples/SliderActions.tsx, packages/react-core/src/components/Slider/examples/Slider.md, packages/react-core/src/demos/HelperText.md
Replaces MinusIcon import and JSX usage with RhUiMinusIcon in HelperTextItem (defaultVariantIcons.indeterminate), NumberInput (minus button icon), and SliderActions (startActions minus button). Slider.md updates the shared import. HelperText.md removes the now-unused MinusIcon import.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • thatblindgeye
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing MinusIcon with RhUiMinusIcon across multiple components and files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-minus-icon-with-rh-ui-minus branch from d01544b to 1bedb7f Compare June 23, 2026 22:29
@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 24, 2026 01:38
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants