Skip to content

fix(ExpandIcon): Replace ExpandIcon with RhUiExpandIcon#12523

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-expand-icon-with-rh-ui-expand
Open

fix(ExpandIcon): Replace ExpandIcon with RhUiExpandIcon#12523
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-expand-icon-with-rh-ui-expand

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the expand/collapse icon used in the toolbar component to use a refreshed icon variant.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21e81c54-a33a-4e73-890d-eaa7da6feeda

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and 52bc2ac.

📒 Files selected for processing (2)
  • packages/react-core/src/demos/Toolbar.md
  • packages/react-core/src/demos/examples/Toolbar/ConsoleLogViewerToolbar.tsx

Walkthrough

In the ConsoleLogViewerToolbar.tsx demo example and its accompanying Toolbar.md documentation, the expand icon is swapped from ExpandIcon to RhUiExpandIcon imported from the rh-ui-expand-icon module of @patternfly/react-icons. No logic or other behavior is altered.

Changes

Toolbar Expand Icon Replacement

Layer / File(s) Summary
Replace ExpandIcon with RhUiExpandIcon
packages/react-core/src/demos/examples/Toolbar/ConsoleLogViewerToolbar.tsx, packages/react-core/src/demos/Toolbar.md
Replaces the ExpandIcon import with RhUiExpandIcon from rh-ui-expand-icon, and updates the "Expand" toolbar button's icon prop and the markdown demo import accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • patternfly/patternfly-react#12456: Performs the same icon replacement pattern in toolbar/Nav examples, swapping LinkIcon for RhUiLinkIcon across imports and render sites.

Suggested reviewers

  • thatblindgeye
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing ExpandIcon with RhUiExpandIcon, which matches the primary objective of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 24, 2026 01:39
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants