Skip to content

fix(FilterIcon): Replace FilterIcon with RhUiFilterFillIcon#12524

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-filter-icon-with-rh-ui-filter-fill
Open

fix(FilterIcon): Replace FilterIcon with RhUiFilterFillIcon#12524
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-filter-icon-with-rh-ui-filter-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated filter icon appearance across toolbar, filter, and table components in examples and documentation for improved visual consistency throughout the design system.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 410bfb17-c19b-4581-b9b1-41aff1a146cf

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and d1d8d4c.

📒 Files selected for processing (28)
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarComponentManagedToggleGroups.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarConsumerManagedToggleGroups.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarStacked.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx
  • packages/react-core/src/demos/Filters/FilterDemos.md
  • packages/react-core/src/demos/Filters/examples/FilterAttributeSearch.tsx
  • packages/react-core/src/demos/Filters/examples/FilterCheckboxSelect.tsx
  • packages/react-core/src/demos/Filters/examples/FilterFaceted.tsx
  • packages/react-core/src/demos/Filters/examples/FilterMixedSelectGroup.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSameSelectGroup.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSingleSelect.tsx
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/Tabs.md
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
  • packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarVisibilityDemo.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-table/src/demos/examples/TableColumnManagement.tsx
  • packages/react-table/src/demos/examples/TableColumnManagementWithDraggable.tsx
  • packages/react-table/src/demos/examples/TableCompact.tsx
  • packages/react-table/src/demos/examples/TableCompoundExpansion.tsx
  • packages/react-table/src/demos/examples/TableFilterable.tsx
  • packages/react-table/src/demos/examples/TableStaticBottomPagination.tsx

Walkthrough

All usages of FilterIcon (from @patternfly/react-icons/.../filter-icon) are replaced with RhUiFilterFillIcon (from @patternfly/react-icons/.../rh-ui-filter-fill-icon) across Toolbar, Filter, Table, PrimaryDetail, and Tabs examples and demos in react-core, react-table, and react-integration packages. No logic, structure, or API surface changes are made.

Changes

FilterIcon → RhUiFilterFillIcon icon replacement

Layer / File(s) Summary
Toolbar example icon swap
packages/react-core/src/components/Toolbar/examples/Toolbar.md, packages/react-core/src/components/Toolbar/examples/Toolbar*.tsx
Markdown import and five TSX example files replace FilterIcon import and toggleIcon prop usages with RhUiFilterFillIcon.
Filter demo icon swap
packages/react-core/src/demos/Filters/FilterDemos.md, packages/react-core/src/demos/Filters/examples/Filter*.tsx
Filter demo markdown and all filter example components replace FilterIcon with RhUiFilterFillIcon in MenuToggle icon props and ToolbarToggleGroup toggleIcon props.
PrimaryDetail and Tabs demo icon swap
packages/react-core/src/demos/PrimaryDetail.md, packages/react-core/src/demos/Tabs.md, packages/react-core/src/demos/examples/PrimaryDetail/..., packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx
Markdown files and corresponding TSX demo components replace FilterIcon import and toggleIcon prop with RhUiFilterFillIcon.
Integration test toolbar demo icon swap
packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarVisibilityDemo.tsx
Integration test components update the icon import and all ToolbarToggleGroup toggleIcon usages to RhUiFilterFillIcon.
Table demo icon swap
packages/react-table/src/demos/Table.md, packages/react-table/src/demos/examples/Table*.tsx
Table demo markdown and all table example files replace FilterIcon imports and MenuToggle/ToolbarToggleGroup icon usages with RhUiFilterFillIcon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • thatblindgeye
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: replacing FilterIcon with RhUiFilterFillIcon across multiple files in the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 24, 2026 01:39
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants