fix(plugin-cloud-storage): prevent deleting original file when duplicating #14961
+4
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the
beforeChangehook in thecloud-storage-pluginto only delete files from storage when the operation isupdate, not duringcreate(which includes duplication).Why
When duplicating a media document, the
originalDocparameter is populated with the source document being duplicated. The existing conditionif (originalDoc)incorrectly triggered file deletion, removing the original file from cloud storage (R2/S3/etc.) while the original database document still referenced it.This resulted in:
How
operationto the destructured hook parametersif (originalDoc)toif (originalDoc && operation === 'update')