Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document gateway JWT for upstream MCP server authentication #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Document gateway JWT for upstream MCP server authentication #623
Changes from all commits
e74b6fa30caa5b62447fff14d3a161f4aeaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Flow diagram edge not updated to match this table row
This row now mentions the signed
X-Gateway-AuthJWT, but the Data Flow diagram edge a few lines above (theGW -->|"Streamable HTTP +<br/>upstream OAuth tokens"| MCPedge) was not updated, so the diagram and this table disagree.(Copilot raised the same disagreement on this line; the actual fix is on that diagram edge.)
Suggestion: update the diagram edge to match:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sequence-diagram claim list omits
nbfThe note enumerates the signed claims as
{iss, sub, aud, exp, iat, jti, tenant}but omitsnbf, which the JWT claims table below (thenbfrow) and the implementation both include (gateway/src/clients/gateway_jwt.rssetsnbf = now - NBF_LEEWAY_SECS). Because the note explicitly lists each claim, the omission reads as ifnbfisn't signed.Suggestion: Add
nbfto the list: