Skip to content

[ENHANCEMENT] add some missing functionalities from core#144

Merged
shahrokni merged 2 commits into
mainfrom
add_missing_functionalities
May 28, 2026
Merged

[ENHANCEMENT] add some missing functionalities from core#144
shahrokni merged 2 commits into
mainfrom
add_missing_functionalities

Conversation

@shahrokni
Copy link
Copy Markdown
Contributor

Some missing functionalities from core which are directly used by the plugins.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni requested a review from a team as a code owner May 28, 2026 14:43
@shahrokni shahrokni requested review from Nexucis and removed request for a team May 28, 2026 14:43
Comment thread components/src/utils/transform-data.ts Outdated
// See the License for the specific language governing permissions and
// limitations under the License.

import { Transform } from '@perses-dev/core';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import from somewhere else ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid mistake sorry

// See the License for the specific language governing permissions and
// limitations under the License.

import { Transform, transformData } from '@perses-dev/core';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import from somewhere else ?

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni requested a review from Nexucis May 28, 2026 15:43
@shahrokni shahrokni merged commit 250d5bb into main May 28, 2026
12 checks passed
@shahrokni shahrokni deleted the add_missing_functionalities branch May 28, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants