Enforce method to not have docblock#237
Open
claudiu-cristea wants to merge 6 commits intopfrenssen:8.3.xfrom
Open
Enforce method to not have docblock#237claudiu-cristea wants to merge 6 commits intopfrenssen:8.3.xfrom
claudiu-cristea wants to merge 6 commits intopfrenssen:8.3.xfrom
Conversation
klausi
requested changes
Dec 28, 2024
Collaborator
klausi
left a comment
klausi
left a comment
There was a problem hiding this comment.
thanks - can you introduce this in a way that existing tests stay as is?
| if ($tokens[$commentEnd]['code'] !== T_DOC_COMMENT_CLOSE_TAG | ||
| && $tokens[$commentEnd]['code'] !== T_COMMENT | ||
| ) { | ||
| if ($methodName === '__construct') { |
Collaborator
There was a problem hiding this comment.
we must not treat constructors in a special way. Comments on constructors are good and we need to allow them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://www.drupal.org/project/coder/issues/3477407