Skip to content

feat: add validation for file extensions in apply command#434

Open
NFUChen wants to merge 1 commit into
pgplex:mainfrom
NFUChen:feat/upstream-pr-validate-state-file
Open

feat: add validation for file extensions in apply command#434
NFUChen wants to merge 1 commit into
pgplex:mainfrom
NFUChen:feat/upstream-pr-validate-state-file

Conversation

@NFUChen
Copy link
Copy Markdown

@NFUChen NFUChen commented May 15, 2026

No description provided.

@NFUChen NFUChen marked this pull request as ready for review May 15, 2026 04:19
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 15, 2026

Greptile Summary

This PR adds early file-extension validation to the apply command. The main changes are:

  • Rejects JSON-looking paths passed to --file with a suggestion to use --plan.
  • Rejects SQL-looking paths passed to --plan with a suggestion to use --file.
  • Adds unit tests for case-insensitive extension checks and allowed file names.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
cmd/apply/apply.go Adds CLI-side validation for likely --file and --plan flag mix-ups before apply execution.
cmd/apply/apply_test.go Adds tests covering rejected .json schema inputs, rejected .sql plan inputs, and accepted valid extensions.

Reviews (1): Last reviewed commit: "feat: add validation for file extensions..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants