Skip to content

chore: skip HeredocIndentationFixer class to preserve heredoc alignment.#8

Merged
terabytesoftw merged 1 commit into
mainfrom
fix_mini_5
May 6, 2026
Merged

chore: skip HeredocIndentationFixer class to preserve heredoc alignment.#8
terabytesoftw merged 1 commit into
mainfrom
fix_mini_5

Conversation

@terabytesoftw
Copy link
Copy Markdown
Contributor

Pull Request

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bugfix (non-breaking change that fixes an issue)
  • CI/build configuration
  • Documentation update
  • New feature (non-breaking change that adds functionality)
  • Refactoring (no functional changes)

@terabytesoftw
Copy link
Copy Markdown
Contributor Author

@codex review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9cf50381-75d1-477f-8585-e384f75e001b

📥 Commits

Reviewing files that changed from the base of the PR and between 5e5773b and 3bfad73.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/ecs.php
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: linter / Super Linter
  • GitHub Check: linter / Super Linter
🔇 Additional comments (4)
CHANGELOG.md (1)

10-10: Changelog entry is clear and aligned with the PR objective.

This accurately documents the behavior change and helps consumers understand why heredoc formatting behavior changed.

src/ecs.php (3)

12-12: Import is appropriate for the new skip rule.

The added fixer import is correctly scoped and directly used by the skip configuration below.


30-35: Configured-rule formatting cleanup is consistent and non-functional.

These inline array rewrites preserve existing rule behavior while improving config compactness.

Also applies to: 79-80


100-101: Skip rule correctly implements the heredoc-alignment bugfix.

Disabling HeredocIndentationFixer here matches the PR goal and cleanly isolates the intended behavior change.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated build configuration settings
    • Added changelog entry documenting configuration updates

Walkthrough

A skip configuration for HeredocIndentationFixer was added to the ECS configuration file to preserve heredoc alignment, with supporting fixer configurations reformatted for consistency and documented in the CHANGELOG.

Changes

HeredocIndentationFixer Skip Configuration

Layer / File(s) Summary
Import & Setup
src/ecs.php
Added import for HeredocIndentationFixer class.
Skip Configuration
src/ecs.php
Configured ECS to skip HeredocIndentationFixer to preserve heredoc alignment.
Formatting Cleanup
src/ecs.php
Converted ClassDefinitionFixer, NullableTypeDeclarationFixer, and PhpUnitTestCaseStaticMethodCallsFixer configurations from multi-line to single-line format.
Documentation
CHANGELOG.md
Documented the HeredocIndentationFixer skip in version 0.3.1 under development.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

bug

Poem

🐰 Hop, hop, the heredocs stay aligned,
No indentation fixes shall unwind,
With config so clean and rules rearranged,
The formatting changed, yet nothing estranged!
A skip so wise, a rabbit's delight! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: skipping HeredocIndentationFixer to preserve heredoc alignment, which matches the changeset modifications in both CHANGELOG.md and src/ecs.php.
Description check ✅ Passed The description is a pull request template with checkboxes indicating the change type (bugfix). While minimal in detail, it is related to the changeset as it documents this as a bugfix, which is appropriate for the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_mini_5

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 PHPStan (2.1.54)

PHPStan was skipped because the sandbox runner could not parse its output.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3bfad73ae4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ecs.php
@terabytesoftw terabytesoftw added the bug Something isn't working label May 6, 2026
@terabytesoftw terabytesoftw merged commit ad516f9 into main May 6, 2026
21 checks passed
@terabytesoftw terabytesoftw deleted the fix_mini_5 branch May 6, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant