Add partitioned for setcookie and setrawcookie#5051
Open
jordikroon wants to merge 2 commits intophp:masterfrom
Open
Add partitioned for setcookie and setrawcookie#5051jordikroon wants to merge 2 commits intophp:masterfrom
jordikroon wants to merge 2 commits intophp:masterfrom
Conversation
jordikroon
force-pushed
the
docs/cookie-partitioned
branch
2 times, most recently
from
ec542de to
201478e
Compare
Contributor
|
Could you please rebase against current master? |
jordikroon
force-pushed
the
docs/cookie-partitioned
branch
from
8e64af8 to
9434c94
Compare
jordikroon
force-pushed
the
docs/cookie-partitioned
branch
from
24239d9 to
af182be
Compare
Member
Author
|
@cweiske PR has been rebased. (ignore the close/reopen). Thanks for the ping. |
cweiske
requested changes
Mar 6, 2026
cweiske
requested changes
Mar 7, 2026
| <member> | ||
| <link linkend="ini.session.cookie-httponly">session.cookie_httponly</link> | ||
| </member> | ||
| <member> |
Contributor
There was a problem hiding this comment.
Shouldn't the new config option be listed in the return value, too?
| <member> | ||
| <link linkend="ini.session.cookie-httponly">session.cookie_httponly</link> | ||
| </member> | ||
| <member> |
Contributor
There was a problem hiding this comment.
Shouldn't the new config option be listed in $lifetime_or_options, too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation for the new "partitioned" cookie option introduced in PHP 8.5.0 (CHIPS support). Updates include:
Ref: #4886