Skip to content

Sync newly added parameters#5074

Merged
kocsismate merged 8 commits intophp:masterfrom
kocsismate:php85-sync7
Jan 15, 2026
Merged

Sync newly added parameters#5074
kocsismate merged 8 commits intophp:masterfrom
kocsismate:php85-sync7

Conversation

@kocsismate
Copy link
Copy Markdown
Member

No description provided.

@bukka
Copy link
Copy Markdown
Member

bukka commented Jan 3, 2026

The OpenSSL part LGTM

Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use <simpara> instead of <para> where able, and create an XML entity for the locale parameter and changelog of the Grapheme functions.

Comment thread reference/intl/grapheme/grapheme-str-split.xml Outdated
Comment thread reference/soap/soapclient/dorequest.xml Outdated
Comment thread reference/soap/soapfault/construct.xml Outdated
Comment thread reference/soap/soapserver/fault.xml Outdated
Comment thread reference/soap/soapserver/fault.xml Outdated
Comment thread reference/soap/soapfault/construct.xml Outdated
Comment thread reference/openssl/functions/openssl-public-encrypt.xml Outdated
Comment thread reference/openssl/functions/openssl-private-decrypt.xml Outdated
Comment thread reference/openssl/functions/openssl-private-decrypt.xml Outdated
Comment thread reference/openssl/functions/openssl-public-encrypt.xml Outdated
Comment thread reference/intl/grapheme/grapheme-substr.xml Outdated
Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please use the new entity on the remaining grapheme pages.

Comment thread reference/soap/soapfault/construct.xml Outdated
Comment thread language-snippets.ent
Comment thread reference/intl/grapheme/grapheme-substr.xml Outdated
Comment thread reference/intl/grapheme/grapheme-strstr.xml Outdated
Comment thread reference/intl/grapheme/grapheme-strrpos.xml Outdated
Comment thread reference/intl/grapheme/grapheme-strripos.xml Outdated
Copy link
Copy Markdown
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for SOAP

Co-authored-by: Gina Peter Banyard <girgias@php.net>
@kocsismate kocsismate merged commit 9a8c593 into php:master Jan 15, 2026
2 checks passed
@kocsismate kocsismate deleted the php85-sync7 branch January 15, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants