-
Notifications
You must be signed in to change notification settings - Fork 422
ci: verbose logs for StaticPHP #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We should upload logs in case of failure instead. I thought I did that already, but I guess I may have missed a place. The debug logs here aren't all that useful, because GitHub will fail displaying enough information if it happens late in the build. |
|
|
|
@henderkes actually, that's not easy to upload a separate log file because the file is generated in the Docker build context. Logging the error stderr seems to be the way to go. If's too big for the GitHub UI, it's always possible to download the raw logs. |
|
Looks like the CI is also red for gnu, have to look what that is. |
henderkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dunglas can you please look at the XCADDY_ARGS change? spc's --build-frankenphp method uses SPC_CMD_VAR_FRANKENPHP_XCADDY_MODULES and automatically appends the frankenphp ones.
|
@henderkes LGTM! |
I'll fix that in spc... I really want to drop glibc 2.17 support outside of zig, though. Since we'll switch to php 8.5 by then, that should be alright. |
henderkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dunglas feel free to merge
|
Thank you Marc! |
No description provided.