Skip to content

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Dec 15, 2025

No description provided.

@henderkes
Copy link
Contributor

We should upload logs in case of failure instead. I thought I did that already, but I guess I may have missed a place.

The debug logs here aren't all that useful, because GitHub will fail displaying enough information if it happens late in the build.

@dunglas
Copy link
Member Author

dunglas commented Dec 15, 2025

Do you want to work on that @henderkes? (edit: I'm on it)
To be honest, my only goal for now is to find out why the static build is red to tag a release :D

@dunglas
Copy link
Member Author

dunglas commented Dec 15, 2025

@henderkes actually, that's not easy to upload a separate log file because the file is generated in the Docker build context.

Logging the error stderr seems to be the way to go. If's too big for the GitHub UI, it's always possible to download the raw logs.

@henderkes
Copy link
Contributor

Looks like the CI is also red for gnu, have to look what that is.

Copy link
Contributor

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dunglas can you please look at the XCADDY_ARGS change? spc's --build-frankenphp method uses SPC_CMD_VAR_FRANKENPHP_XCADDY_MODULES and automatically appends the frankenphp ones.

@henderkes henderkes self-requested a review December 15, 2025 14:57
@dunglas
Copy link
Member Author

dunglas commented Dec 15, 2025

@henderkes LGTM!

@henderkes
Copy link
Contributor

#27 1366.1 /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: /go/src/app/dist/static-php-cli/buildroot/lib/libwebp.a(lossless_avx2.c.o): in function `PredictorAdd12_AVX2':
#27 1366.1 lossless_avx2.c:(.text+0x592): undefined reference to `_mm256_cvtsi256_si32'
#27 1366.1 /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: lossless_avx2.c:(.text+0x5f3): undefined reference to `_mm256_cvtsi256_si32'

I'll fix that in spc... I really want to drop glibc 2.17 support outside of zig, though. Since we'll switch to php 8.5 by then, that should be alright.

Copy link
Contributor

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dunglas feel free to merge

@dunglas dunglas merged commit a8f75d0 into main Dec 15, 2025
88 of 91 checks passed
@dunglas dunglas deleted the ci/spc-logs branch December 15, 2025 19:13
@dunglas
Copy link
Member Author

dunglas commented Dec 15, 2025

Thank you Marc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants