feat: allow to customize EmbeddedAppPath#2198
Merged
Conversation
henderkes
reviewed
Feb 17, 2026
| // EmbeddedAppPath contains the path of the embedded PHP application (empty if none). | ||
| // It can be set at build time using -ldflags to override the default extraction path: | ||
| // | ||
| // go build -ldflags "-X github.com/dunglas/frankenphp.EmbeddedAppPath=/app" ... |
Contributor
There was a problem hiding this comment.
is there no simpler way than hijacking ldflags for this?
Member
Author
There was a problem hiding this comment.
What would be the benefit? It's a niche use, and ldflags are designed for that.
Contributor
There was a problem hiding this comment.
Yeah that's true. We should expose it in build-static.sh though.
Member
Author
There was a problem hiding this comment.
It's already exposed through XCADDY_ARGS.
dunglas
force-pushed
the
feat/custom-EmbeddedAppPath
branch
from
f44833d to
cfcbe70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows customizing the path where to extract the embedded app. This is useful when the app itself depends on absolute pathes.