Conversation
Disable the execution timer in frankenphp_worker_request_shutdown() to prevent stale timers from firing between requests. Also fix evaluation order in frankenphp_handle_request() to check for shutdown before calling frankenphp_worker_request_startup(). Fixes #2205 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Not sure this will fix it. On fatal error Line 1317 in b02d99a |
Contributor
|
I could imagine that Might be necessary to completely restart the thread if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2205. At least I hope so.
Disable the execution timer in
frankenphp_worker_request_shutdown()to prevent stale timers from firing between requests. Also, fix evaluation order infrankenphp_handle_request()to check for shutdown before callingfrankenphp_worker_request_startup().