chore: improve errror message when passing named parameter for variadic #21012
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/cc @Girgias @kocsismate, given you have both worked on error messages historically. |
Girgias
approved these changes
Jan 24, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I think the new wording makes more sense, as the current one is very confusing.
I was having a quick look to see why this error message appears, and it's due to the fact that the +/* ZPP specifiers (and the fast ZPP Z_PARAM_VARIADIC equivalent) don't support the named parameters. And it doesn't seem like it's very easy or even sensible to migrate to the Z_PARAM_VARIADIC_WITH_NAMED fast ZPP specifier that does support the named args.
iluuu1994
reviewed
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit confused when I encountered the error
does not accept unknown named parameters.The issue was that I passed an associative array to a variadic parameter, which made the message misleading.
Because of that, I felt a clearer error message would be more appropriate in this case.
I changed the error message from
<function> does not accept unknown named parametersto<function> does not accept named arguments for variadic parameters.The discussion about this problem was touched in #11026