Fix memory leaks when adding certificate to store fails #21030
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When certificate
certexists, but is not added to the store, it causes memory leaks. The error handling was already existing but the freeing only happened on the success case.One could also ponder whether it is necessary to inform the user when adding a certificate failed or signal this in some way.
Part of the leak report:
This was found by a hybrid static-dynamic analyser that looks for inconsistent handling of error checks in bindings.