Additional SNMP library output formatting options#21502
Draft
eskyuu wants to merge 7 commits intophp:masterfrom
Draft
Additional SNMP library output formatting options#21502eskyuu wants to merge 7 commits intophp:masterfrom
eskyuu wants to merge 7 commits intophp:masterfrom
Conversation
Girgias
reviewed
Mar 24, 2026
Comment on lines
+1514
to
+1515
| netsnmp_ds_set_boolean(NETSNMP_DS_LIBRARY_ID, NETSNMP_DS_LIB_NUMERIC_TIMETICKS, (int) a1); | ||
| RETURN_TRUE; |
Member
There was a problem hiding this comment.
Unless you're going to do something with the return value of netsnmp_ds_set_boolean() I think just having the function be void is better.
Author
There was a problem hiding this comment.
I'm actually wondering if a generic function like php_snmp_set_output_option(int, bool); would be better. Similar to what we do with SNMP_OID_OUTPUT_*
It would be a similar amount of work to add a new option. The difference would be:
- Add a new const to snmp.stub.php instead of a function
- Add new const to switch statement in php_snmp_set_output_option instead of copying the function
I'll have a think, but am leaning towards one function instead of many new ones.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SNMP library has more formatting options than php-snmp allows. This PR adds some additional functions to control how the net-snmp library returns results to PHP.