ext/standard: Optimize symbol table lookup by using zend_hash_lookup#21537
Open
arshidkv12 wants to merge 1 commit intophp:masterfrom
Open
ext/standard: Optimize symbol table lookup by using zend_hash_lookup#21537arshidkv12 wants to merge 1 commit intophp:masterfrom
arshidkv12 wants to merge 1 commit intophp:masterfrom
Conversation
iluuu1994
reviewed
Mar 26, 2026
| ZVAL_MAKE_REF_EX(entry, 2); | ||
| } | ||
| if ((orig_var = zend_hash_find(symbol_table, final_name)) != NULL) { | ||
| if ((orig_var = zend_hash_lookup(symbol_table, final_name)) != NULL) { |
Member
There was a problem hiding this comment.
They are not fully equivalent. zend_hash_lookup() will never return NULL when the element wasn't found, but a new null-initialized zval to be populated. So the branch should be removed. The rest looks functionally identical, but you'll also need to verify it's actually better/faster.
Contributor
Author
There was a problem hiding this comment.
Got it, I'll verify the behavior and performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced zend_hash_find() with zend_hash_lookup().
Functionality remains unchanged.