ext/XML: Improve invalid value handling for XML_OPTION_SKIP_TAGSTART#22030
Open
LamentXU123 wants to merge 1 commit into
Open
ext/XML: Improve invalid value handling for XML_OPTION_SKIP_TAGSTART#22030LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleaning up implicit cast of
zval_get_longin XML_OPTION_SKIP_TAGSTARTTypes like stdClass or array will cause two warnings currently, which is duplication. For non-numeric string, the original behavior is silently convert it to long (0) and return false with no warning.
So one suggested practice is to check if the type is string|int|bool, if no raise a warning and ret false, if yes than go to
zval_try_get_longand see if it is non-numeric string, if yes raise a warning and ret false.