Skip to content

More improvements to popup prompt #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iMattPro wants to merge 7 commits into
base: main
Choose a base branch
from
Open

More improvements to popup prompt #120

iMattPro wants to merge 7 commits into from

Conversation

@iMattPro
Copy link
Contributor

@iMattPro iMattPro commented Dec 23, 2025 •
edited
Loading

Improvements made in this PR:

  1. Use escape key to close/dismiss/deny the prompt.
  2. Add aria attributes for accessibility.
  3. Add UCP preference in notifications so users can disable the prompt permanently on all their devices, to better comply with GDPR.
Screenshot 2025-12-30 at 8 24 03 AM

@iMattPro iMattPro requested a review from rxu December 26, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rxu rxu Awaiting requested review from rxu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iMattPro