Skip to content

feature: Headers implements TypeSafeGetter #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g105b merged 1 commit into from
Mar 10, 2026
Merged

feature: Headers implements TypeSafeGetter #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Header/Headers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,17 @@
namespace Gt\Http\Header;

use Countable;
use Gt\TypeSafeGetter\NullableTypeSafeGetter;
use Gt\TypeSafeGetter\TypeSafeGetter;
use Iterator;

/**
* @implements Iterator<int, HeaderLine>
* @SuppressWarnings("TooManyPublicMethods")
*/
class Headers implements Iterator, Countable {
class Headers implements Iterator, Countable, TypeSafeGetter {
use NullableTypeSafeGetter;

const COMMA_HEADERS = [
// These cookies use commas within the value, so can't be comma separated.
"cookie-set",
Expand Down
7 changes: 7 additions & 0 deletions test/phpunit/Header/HeadersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

use Gt\Http\Header\HeaderLine;
use Gt\Http\Header\Headers;
use Gt\TypeSafeGetter\TypeSafeGetter;
use PHPUnit\Framework\TestCase;

class HeadersTest extends TestCase {
Expand Down Expand Up @@ -99,6 +100,12 @@ public function testGet() {
self::assertEquals(self::HEADER_ARRAY["Content-Type"], $headers->get("content-type"));
}

public function testTypeSafeGetterInterface():void {
$headers = new Headers(self::HEADER_ARRAY);
self::assertInstanceOf(TypeSafeGetter::class, $headers);
self::assertSame(self::HEADER_ARRAY["Date"], $headers->getString("date"));
}

public function testGetMultiple() {
$headers = new Headers(self::HEADER_ARRAY);
$headers->add("Accept", "application/json", "application/xml");
Expand Down