Remove callable.nonNativeMethod#5004
Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom Feb 19, 2026
Merged
Conversation
VincentLanglet
force-pushed
the
fixx/13596
branch
from
5edf987 to
1f24e49
Compare
VincentLanglet
force-pushed
the
fixx/13596
branch
from
d21c392 to
1092e24
Compare
| ->build(); | ||
|
|
||
| return $errors; | ||
| return $this->methodCallCheck->check($scope, $methodNameName, $node->getVar(), $node->getName())[0]; |
Member
There was a problem hiding this comment.
I think the returning of the array shape with the method reflection might have been introduced exactly because of this. It might be possible to simplify the return type and let it just returns errors instead of the tuple.
Contributor
Author
There was a problem hiding this comment.
I looked and the shape seems to always have existed, and the methodReflection is used somewhere else
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by phpstan/phpstan#13596 (comment)
Closes phpstan/phpstan#13596
cf https://onlinephp.io/c/5de57