Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage 87.32% 87.33%
=======================================
Files 52 52
Lines 6516 6520 +4
Branches 728 731 +3
=======================================
+ Hits 5690 5694 +4
Misses 804 804
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR extends the dumped road-network metadata by adding a coilcode field to the edges table in the simulation SQLite DB, and updates the web viewer to read that field. It also bumps the DSF patch version and updates release metadata.
Changes:
- Add
coilcodecolumn to theedgestable schema and populate it from each street’s counter name when dumping the network. - Update the webapp’s edge loader query to fetch
coilcodeand attach it to loaded edge objects. - Bump version metadata (DSF version +
CITATION.cff).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| webapp/script.js | Reads coilcode from edges and attaches it to edge objects loaded from the SQLite DB. |
| src/dsf/mobility/FirstOrderDynamics.cpp | Adds coilcode column to edges schema and inserts per-edge coil identifier when dumping the network. |
| src/dsf/dsf.hpp | Patch version bump from 5.3.2 to 5.3.3. |
| CITATION.cff | Updates version/date-released to match the new patch release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.