Skip to content

test(analytics): comprehensive integration and edge-case tests #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreBrisorgueil merged 3 commits into from
Mar 25, 2026
Merged

test(analytics): comprehensive integration and edge-case tests #3308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a627ad
test(analytics): add comprehensive integration and edge-case tests
PierreBrisorgueil Mar 25, 2026
b737355
fix(skills): align verify, feature, and pull-request with Vue convent…
PierreBrisorgueil Mar 25, 2026
e14b9e7
fix(analytics): update comprehensive tests for async init and query s…
PierreBrisorgueil Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/feature/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ If an action affects another user:
- [ ] Error responses have user-friendly `description` field

**Tests:**
- [ ] Tests: add unit + integration tests. Add E2E (`*.e2e.tests.js`) only if the change affects a critical user flow (auth, org onboarding, invite/join).
- [ ] Tests: add unit (`*.unit.tests.js`) + integration (`*.integration.tests.js`) tests. Add E2E (`*.e2e.tests.js`) only if the change affects a critical user flow (auth, org onboarding, invite/join).

**Modularity:**
- [ ] Isolated in ONE module (or justified)
Expand Down
5 changes: 3 additions & 2 deletions .claude/skills/pull-request/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ REPEAT:
6. If actionable comments → fix all, /verify, commit, push, reply, resolve, consecutive_zero=0, GOTO 1
7. If non-actionable unresolved → reply all explaining why, resolve all, consecutive_zero=0, GOTO 5
8. If zero unresolved threads → consecutive_zero++
if consecutive_zero >= 3 → check branch protection (see 6f), then STOP ✓
if consecutive_zero >= 3 (~9 min) → check branch protection (see 6f), then STOP ✓
else GOTO 3
```

Expand Down Expand Up @@ -202,14 +202,15 @@ Wait 30s before watching CI (regular or force-push). Loop back to 6a. Never post

### 6f. Stop condition

CI green **and** 2 consecutive passes with zero unresolved threads. Mergeable status is also checked after every CI pass (step 2b) — conflicts cause an early stop. Final branch protection check:
CI green **and** 3 consecutive passes (~9 min of grace periods) with zero unresolved threads. Mergeable status is also checked after every CI pass (step 2b) — conflicts cause an early stop. Final branch protection check:

```bash
gh pr view "$PR" --json reviewDecision,mergeable | jq '{reviewDecision, mergeable}'
```

- `APPROVED` + `MERGEABLE` → **STOP ✓**
- `REVIEW_REQUIRED` → report to user, stop
- `CHANGES_REQUESTED` → report to user, stop
- `BLOCKED` → report details to user

**Safety limit:** 10 iterations max — report to user if still unresolved.
Expand Down
Loading
Loading