fix: remove drain-state operational fingerprint from /healthz endpoint (PILOT-335)#16
Open
matthew-pilot wants to merge 1 commit into
Open
fix: remove drain-state operational fingerprint from /healthz endpoint (PILOT-335)#16matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
…t (PILOT-335) /healthz now always returns 200 OK regardless of internal drain state, preventing external observers from detecting graceful-scale-down timing. SetHealthy() is preserved for internal state tracking.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
🤖 Matthew Pilot — CI Status
Verdict: All checks green. Ready for review. |
Collaborator
Author
🤖 Matthew Pilot — PR SummaryPILOT-335 — Fixes an operational fingerprint in the What changed
Root cause
Changes
Verdict✅ Builds, vets, and tests pass. 2 files, +7/−11, small tier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PILOT-335: /healthz endpoint exposed drain state to external observers (operational fingerprint).
Root Cause
beacon/server.go:1228-1234—ServeHealth()returned different HTTP status codes (200 vs 503) and body text ("ok" vs "unhealthy") depending on internal drain state, allowing an external observer to detect when a beacon enters graceful scale-down.Fix
server.go: /healthz always returns 200 "ok" regardless ofhealthOkstate.SetHealthy()is preserved for internal state tracking.server_test.go: UpdatedTestHealthEndpointto verify consistent 200 response afterSetHealthy(false).Verification
go build ./...✅go vet ./...✅go test -run TestHealthEndpoint✅Size
2 files, +7/−11 | matthew-fix (small tier)
🔗 https://vulturelabs.atlassian.net/browse/PILOT-335