fix: filter subdirectories before inbox cap check in evictInboxOverflow (PILOT-183)#4
Closed
matthew-pilot wants to merge 1 commit into
Closed
fix: filter subdirectories before inbox cap check in evictInboxOverflow (PILOT-183)#4matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
…ow (PILOT-183) evictInboxOverflow counted subdirectory entries in the initial len(entries) <= cap short-circuit at line 307. If a mailbox had cap real files plus one subdir, the guard let us through — but after filtering IsDir() in the collection pass, len(files) == cap and the second check returned silently. Subdirs poisoned the eviction trigger, causing mailbox to grow unbounded. Fix: count only !e.IsDir() entries for the initial capacity guard, so subdirectories never inflate the file count.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
evictInboxOverflowinservice.gocounted subdirectory entries in the initiallen(entries) <= capshort-circuit. If a mailbox had exactly cap real files plus one subdirectory, the guard allowed execution to proceed — but after filteringIsDir()in the collection pass,len(files) == capand the second check returned silently, evicting nothing. Subdirectories poisoned the eviction trigger, allowing the inbox to grow unbounded.Fix
Filter only
!e.IsDir()entries for the initial capacity guard at line 307, so subdirectories never inflate the file count.Changes
service.go: +10 / -1 lines inevictInboxOverflowVerification
Jira
🔗 https://vulturelabs.atlassian.net/browse/PILOT-183