fix(ci): checkout pilot-protocol/common (PILOT-349)#7
Merged
Conversation
The 'deps: switch shared types to common' merge added github.com/pilot-protocol/common as a dependency with 'replace .. => ../common', but didn't update ci.yml to check that sibling out. Result: every main CI run since then has been red on go test with '../common/go.mod: no such file or directory'. Fix: add a 'Checkout common' step before setup-go, mirroring the existing 'Checkout web4' pattern. Closes PILOT-349.
PR #4 (deps: switch shared types to common) migrated production code to common/* but introduced new test code in zz_helpers_test.go / zz_handshake_manager_bootstrap_test.go with type mismatches: - testRuntime.regClient was declared as *common/registry/client.Client but regtestutil.StartTestRegistry returns *TeoSlayer/pilotprotocol/pkg/registry/client.Client, and tests call .SetSigner / .RegisterWithKey which only exist on the concrete TeoSlayer type - daemon.Connection.RemoteAddr field is TeoSlayer/pkg/protocol.Addr (web4 hasn't migrated) but the test was constructing common/protocol.Addr - testStreamAdapter / testDaemonListener returned TeoSlayer Addr where coreapi.Addr expected Fixes: - testRuntime.regClient: change to *tregistryclient.Client (TeoSlayer concrete) — implicit RegistryClient interface satisfaction is structural so production code continues to work - bootstrap_test: import tprotocol alias and construct tprotocol.Addr for daemon fields - helpers_test: convert TeoSlayer Addr → coreapi.Addr via struct literal (fields identical) Verified locally: go test ./... → PASS
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'deps: switch shared types to common' merge added
github.com/pilot-protocol/commonas a dependency withreplace .. => ../common, but didn't update ci.yml to check that sibling out. Result: every main CI run since then has been red ongo testwith../common/go.mod: no such file or directory.Fix: add a
Checkout commonstep beforesetup-go, mirroring the existingCheckout web4pattern. Same fix landed in pilot-protocol/examples#4.Closes PILOT-349.