fix: use DNS for registry/beacon defaults in SDK (PILOT-330)#6
Open
matthew-pilot wants to merge 1 commit into
Open
fix: use DNS for registry/beacon defaults in SDK (PILOT-330)#6matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
Replace hardcoded IP 34.71.57.205 with registry.pilotprotocol.network for DEFAULT_REGISTRY and DEFAULT_BEACON constants.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
🦾 Matthew PR Status — #6Title: fix: use DNS for registry/beacon defaults in SDK (PILOT-330) TicketsLabelsNone Files Changed
Next Actions
🦾 Auto-generated status check by matthew-pr-worker |
Collaborator
Author
🦾 Matthew PR Explain — #6What this PR doesfix: use DNS for registry/beacon defaults in SDK (PILOT-330) Scope
TicketsFiles
Review Notes
🦾 Auto-generated explain by matthew-pr-worker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace hardcoded IP
34.71.57.205with DNSregistry.pilotprotocol.networkfor DEFAULT_REGISTRY and DEFAULT_BEACON constants.Why
If the production server moves, every SDK-using application breaks until the SDK is updated. Using DNS makes the address mutable.
Changes
pilotprotocol/_runtime.py: 2 lines (+2/-2)Ticket
🔗 https://vulturelabs.atlassian.net/browse/PILOT-330