CI: Update LinkChecker URL excludes (#20287)#22469
CI: Update LinkChecker URL excludes (#20287)#22469ti-chi-bot[bot] merged 6 commits intopingcap:release-8.5from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
area/develop
|
@dveeden This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
bot
added
size/XL
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, an automated cherry-pick, appears to have introduced unresolved merge conflict markers into several documentation and configuration files, specifically Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
size/M
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to be a faulty automated cherry-pick, as it has introduced several merge conflicts into the codebase. These conflicts are present in .lycheeignore, ai/integrations/vector-search-integration-overview.md, and develop/dev-guide-third-party-support.md, and must be resolved. Additionally, I've provided a minor suggestion for improving the wording in the new develop/dev-guide-overview.md file.
I am having trouble creating individual review comments. Click here to see my feedback.
.lycheeignore (28-44)
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>), which will prevent it from being parsed correctly. Please resolve the conflict to ensure the link checker ignores the intended URLs.
https://help\.openai\.com/en/articles/.*
https://platform\.openai\.com/docs/.*
https://openai\.com/.*
https://jwt\.io/
https://typeorm\.io/.*
https://dash\.cloudflare\.com/.*
https://centminmod\.com/mydumper\.html
https://docs\.pingcap\.com/tidb/v6\.6/system-variables#tidb_pessimistic_txn_aggressive_locking-new-in-v660
https://docs\.pingcap\.com/tidb/v7\.6/system-variables#tidb_ddl_version-new-in-v760
https://developers\.redhat\.com/blog/2021/01/05/building-red-hat-enterprise-linux-9-for-the-x86-64-v2-microarchitecture-level
https://portal\.azure\.com/.*
develop/dev-guide-overview.md (17)
For better clarity and conciseness, it's preferable to use the singular form "sample code" instead of "sample codes."
Build your application with the language you use by following the guides with sample code.
References
- According to the style guide, you should avoid unnecessary words and repetition. Using 'sample code' instead of 'sample codes' is more concise. (link)
ti-chi-bot
bot
added
size/L
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiancai
removed
the
do-not-merge/hold
qiancai
added
the
needs-cherry-pick-master
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
3 participants
This is an automated cherry-pick of #20287
What is changed, added or deleted? (Required)
The aim is to reduce false positive in the link checker
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?