developer-guide: add a TTL doc (#22464)#22471
developer-guide: add a TTL doc (#22464)#22471ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
area/develop
|
@qiancai This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the TiDB documentation by introducing a dedicated developer guide for the Time To Live (TTL) feature. This change aims to provide a clearer, more focused resource for developers on how to implement and manage data expiration, separating development-specific details from the general TTL overview. The update involves adding a new document, adjusting internal links, and refining the title of the existing main TTL documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new developer guide for the TTL feature, which is a valuable addition for developers. The new documentation is clear and provides a good quick start. However, I've found a critical issue in TOC.md where merge conflict markers are present. This must be resolved. I also have a minor stylistic suggestion for the new markdown file.
TOC.md
Outdated
| <<<<<<< HEAD | ||
| ======= | ||
| - [GB18030](/character-set-gb18030.md) | ||
| - [TTL (Time to Live)](/time-to-live.md) | ||
| >>>>>>> bf6b8f2bc6 (developer-guide: add a TTL doc (#22464)) |
There was a problem hiding this comment.
This file contains merge conflict markers (<<<<<<<, =======, >>>>>>>). Please resolve the conflict before merging.
| <<<<<<< HEAD | |
| ======= | |
| - [GB18030](/character-set-gb18030.md) | |
| - [TTL (Time to Live)](/time-to-live.md) | |
| >>>>>>> bf6b8f2bc6 (developer-guide: add a TTL doc (#22464)) | |
| - [GB18030](/character-set-gb18030.md) | |
| - [TTL (Time to Live)](/time-to-live.md) |
qiancai
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
This is an automated cherry-pick of #22464
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add dev-guide-time-to-live.md in the /develop folder, because "time-to-live.md" could be version specific, while dev-guide-time-to-live.md only provides some basic information for development purpose.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?