Skip to content

tici: fix monitoring port#2708

Merged
xhebox merged 1 commit into
pingcap:feature/ftsfrom
JinheLin:fix_tici_status_port
May 14, 2026
Merged

tici: fix monitoring port#2708
xhebox merged 1 commit into
pingcap:feature/ftsfrom
JinheLin:fix_tici_status_port

Conversation

@JinheLin
Copy link
Copy Markdown

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot Bot requested review from kaaaaaaang and srstack May 14, 2026 07:15
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/fts@e969d49). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/cluster/spec/monitoring.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             feature/fts    #2708   +/-   ##
==============================================
  Coverage               ?   46.90%           
==============================================
  Files                  ?      372           
  Lines                  ?    38104           
  Branches               ?        0           
==============================================
  Hits                   ?    17870           
  Misses                 ?    18088           
  Partials               ?     2146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot Bot added the lgtm label May 14, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 14, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-14 07:45:14.085088179 +0000 UTC m=+338082.617867508: ☑️ agreed by xhebox.

@xhebox xhebox merged commit 8d4ba98 into pingcap:feature/fts May 14, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants