Skip to content

fix: show restore defaults only on General settings#1710

Open
UtkarshUsername wants to merge 3 commits intopingdotgg:mainfrom
UtkarshUsername:fix/settings-restore-defaults-button
Open

fix: show restore defaults only on General settings#1710
UtkarshUsername wants to merge 3 commits intopingdotgg:mainfrom
UtkarshUsername:fix/settings-restore-defaults-button

Conversation

@UtkarshUsername
Copy link
Copy Markdown
Contributor

@UtkarshUsername UtkarshUsername commented Apr 3, 2026

Fixes #1709

What Changed

Moved the Restore defaults visibility check into the shared settings header so the button keeps its existing placement but only renders on /settings/general.

Also kept the web settings header height stable between General and Archive so the header does not visually jump when the button is absent.

Why

Restore defaults resets general settings values. Showing it on the Archive page is misleading because that page is not a settings form and the action does not belong to that section. Also, the button doesn't work on the Archive page.

Keeping the button in the shared header preserves the original UI placement, while route-gating it makes the behavior correct. Fixing the header height avoids a visual regression between settings routes.

UI Changes

Before:
image

After:
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk UI-only change that route-gates an existing action button; no data model or backend behavior changes.

Overview
Updates the settings header to only render the Restore defaults button when the current route is /settings/general, avoiding a misleading action on non-general pages.

Also stabilizes the non-Electron header layout by keeping a consistent minimum height so the header doesn’t visually jump when the button is absent.

Written by Cursor Bugbot for commit ef5c9b2. This will update automatically on new commits. Configure here.

Note

Show 'Restore defaults' button only on the General settings page

The "Restore defaults" button in settings.tsx is now conditionally rendered based on the current route, appearing only when location.pathname === "/settings/general". This applies to both the standard web header and the Electron drag-region header.

Macroscope summarized ef5c9b2.

- Add a section header action for restoring defaults
- Scope the restore button to General settings instead of the shared layout
- Remove the layout-level refresh key workaround
- Show the restore defaults action from the shared settings shell
- Keep the general settings panel focused on section content
- Remount the outlet after restore so settings refresh cleanly
- Reserve header height so the restore defaults button no longer shifts layout
- Keep the settings title row aligned on small screens
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3e743613-3a49-4d2e-bce9-61d1c8b1051c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 3, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 3, 2026

Approvability

Verdict: Approved

Simple UI fix that conditionally hides the 'Restore defaults' button when not on the General settings page. The change is self-contained to a single settings layout file with no runtime behavior impact beyond UI visibility.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Settings archive page shows "Restore defaults" even though the action only applies to general settings

1 participant