fix: show restore defaults only on General settings#1710
fix: show restore defaults only on General settings#1710UtkarshUsername wants to merge 3 commits intopingdotgg:mainfrom
Conversation
- Add a section header action for restoring defaults - Scope the restore button to General settings instead of the shared layout - Remove the layout-level refresh key workaround
- Show the restore defaults action from the shared settings shell - Keep the general settings panel focused on section content - Remount the outlet after restore so settings refresh cleanly
- Reserve header height so the restore defaults button no longer shifts layout - Keep the settings title row aligned on small screens
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Simple UI fix that conditionally hides the 'Restore defaults' button when not on the General settings page. The change is self-contained to a single settings layout file with no runtime behavior impact beyond UI visibility. You can customize Macroscope's approvability policy. Learn more. |
Fixes #1709
What Changed
Moved the
Restore defaultsvisibility check into the shared settings header so the button keeps its existing placement but only renders on/settings/general.Also kept the web settings header height stable between General and Archive so the header does not visually jump when the button is absent.
Why
Restore defaultsresets general settings values. Showing it on the Archive page is misleading because that page is not a settings form and the action does not belong to that section. Also, the button doesn't work on the Archive page.Keeping the button in the shared header preserves the original UI placement, while route-gating it makes the behavior correct. Fixing the header height avoids a visual regression between settings routes.
UI Changes
Before:

After:

Checklist
I included a video for animation/interaction changesNote
Low Risk
Low risk UI-only change that route-gates an existing action button; no data model or backend behavior changes.
Overview
Updates the settings header to only render the
Restore defaultsbutton when the current route is/settings/general, avoiding a misleading action on non-general pages.Also stabilizes the non-Electron header layout by keeping a consistent minimum height so the header doesn’t visually jump when the button is absent.
Written by Cursor Bugbot for commit ef5c9b2. This will update automatically on new commits. Configure here.
Note
Show 'Restore defaults' button only on the General settings page
The "Restore defaults" button in settings.tsx is now conditionally rendered based on the current route, appearing only when
location.pathname === "/settings/general". This applies to both the standard web header and the Electron drag-region header.Macroscope summarized ef5c9b2.