Add govulncheck job to lint workflow and fix matrix job result syntax #6435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
mohammedfirdouss
requested review from
Warashi,
Copilot,
ffjlabo and
khanhtc1202
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
mohammedfirdouss
force-pushed
the
feat/add-dependabot-govulncheck
branch
from
c15d4e1 to
148b5a3
Compare
Contributor
Ayushmore1214
left a comment
Ayushmore1214
left a comment
There was a problem hiding this comment.
Adding go module caching would be better for faster CI runs WDYT @mohammedfirdouss ?
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Contributor
Author
Hmm, I think this is a good idea. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6435 +/- ##
==========================================
+ Coverage 28.87% 38.65% +9.77%
==========================================
Files 560 11 -549
Lines 59955 652 -59303
==========================================
- Hits 17313 252 -17061
+ Misses 41321 384 -40937
+ Partials 1321 16 -1305 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Contributor
Author
|
@khanhtc1202 Merge conflict has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#6409
What was addressed
The PR adds two security features:
How it works
.github/dependabot.yml)• Scans Go modules and npm packages weekly
• Monitors multiple directories (root, plugins, tools, web, docs)
• Creates PRs when updates are available
• Limits open PRs to 5 per ecosystem to avoid spam
.github/workflows/lint.yaml)• Runs automatically on every PR and push
• Scans all Go modules in the repository
• Uses a matrix strategy to check each module separately
• Fails the CI if vulnerabilities are found
• Includes a completion job (govulncheck-completed) for branch protection rules
Testing
mohammedfirdouss#1 - see this dependabot that automatically checks for dependency updates in my repo and updates what is necessary then opens a PR.
Check out how the workflow file also catches vulnerabilities, the screenshots show evidences that this would work. I am open to reviews and suggestions.
cc: @khanhtc1202 @eeshaanSA @Warashi @ffjlabo