Skip to content

fix: remove broad exception swallowing in main() #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipe1os merged 1 commit into from
Jun 12, 2026
Merged

fix: remove broad exception swallowing in main() #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 23 additions & 31 deletions src/modelinfo/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,43 +190,35 @@ def main(argv: Sequence[str] | None = None) -> int:

models = []
for model_path in args.file:
try:
info = analyze_model(
model_path,
args.context,
gpu_count,
fetch_tensors=args.tensors,
topology=args.topology,
strategy=args.strategy,
is_vllm=args.vllm,
gpu_vram_gb=gpu_vram_gb if gpu_vram_gb else 0.0,
gpu_util=args.gpu_util
)
models.append((model_path.split("/")[-1], info))
except Exception as e:
console.print(f"[red]Error analyzing model '{model_path}': {e}[/red]")
return 1
info = analyze_model(
model_path,
args.context,
gpu_count,
fetch_tensors=args.tensors,
topology=args.topology,
strategy=args.strategy,
is_vllm=args.vllm,
gpu_vram_gb=gpu_vram_gb if gpu_vram_gb else 0.0,
gpu_util=args.gpu_util
)
models.append((model_path.split("/")[-1], info))

print_compare_info(models, gpu_vram_gb if gpu_vram_gb else args.max_vram, gpu_name=gpu_name_display)
return 0

file_path = args.file[0]

try:
info = analyze_model(
file_path,
args.context,
gpu_count,
fetch_tensors=args.tensors,
topology=args.topology,
strategy=args.strategy,
is_vllm=args.vllm,
gpu_vram_gb=gpu_vram_gb if gpu_vram_gb else 0.0,
gpu_util=args.gpu_util
)
except Exception as e:
console.print(f"[red]Error: {e}[/red]")
return 1
info = analyze_model(
file_path,
args.context,
gpu_count,
fetch_tensors=args.tensors,
topology=args.topology,
strategy=args.strategy,
is_vllm=args.vllm,
gpu_vram_gb=gpu_vram_gb if gpu_vram_gb else 0.0,
gpu_util=args.gpu_util
)

print_model_info(**info, max_vram_gb=gpu_vram_gb if gpu_vram_gb else args.max_vram, gpu_name=gpu_name_display)
return 0
Expand Down
Loading