Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded a top-level v0.11.1 changelog, bumped many crate versions and workspace dependencies, added new workspace crates/dependencies, and inserted per-crate changelog entries. No source-code logic or public API signatures changed in this diff. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@crates/soar-dl/CHANGELOG.md`:
- Line 6: The CHANGELOG entry contains a placeholder commit hash "0000000" in
the line mentioning "Updated the following local packages: soar-utils -
([0000000](...))"; replace that placeholder with the real merge/squash commit
hash before publishing (or remove the markdown link entirely or switch to the
release-plz variable/token your release pipeline provides) so the link is not
dead when published—update the string "0000000" in CHANGELOG.md accordingly.
🧹 Nitpick comments (1)
crates/soar-events/CHANGELOG.md (1)
1-48: Initial changelog includes unrelated historical entries.This is the first release of
soar-events, but the changelog includes many entries from the broader project history (e.g., flatimage, json_where, inspect command) that aren't specific to this crate. Only line 6 is actually aboutsoar-events. This is a knownrelease-plzbehavior for initial releases — it pulls in all reachable git history. Consider trimming to only the relevant entry for clarity, or leave as-is if you're fine with the noise.
QaidVoid
force-pushed
the
release-plz-2026-02-16T17-29-19Z
branch
from
abe73d5 to
2443b50
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/soar-utils/Cargo.toml (1)
13-21:⚠️ Potential issue | 🟠 MajorMove
serial_testfrom[dependencies]to[dev-dependencies].
serial_testis only used within the#[cfg(test)]module incrates/soar-utils/src/path.rsand carries no runtime utility. Placing it in[dependencies]compiles it into production artifacts and transitively pulls it into every downstream crate (soar-config,soar-core,soar-operations, etc.), unnecessarily bloating build graphs.tempfileis correctly placed in[dev-dependencies], confirming the dev-dep section is already established.Suggested fix
[dependencies] blake3 = { workspace = true } miette = { workspace = true } nix = { workspace = true } -serial_test = { workspace = true } thiserror = { workspace = true } [dev-dependencies] +serial_test = { workspace = true } tempfile = { workspace = true }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/soar-utils/Cargo.toml` around lines 13 - 21, Move the test-only crate out of production deps: remove the serial_test entry from the [dependencies] section in Cargo.toml and add the same serial_test = { workspace = true } entry under [dev-dependencies]; verify crates/soar-utils/src/path.rs still builds (the #[cfg(test)] module uses serial_test) and run cargo test to ensure no missing dependency issues.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/soar-config/CHANGELOG.md`:
- Around line 2-6: The 0.6.0 changelog entry is missing the required
[**breaking**] marker for the addition of the Config.system_mode field; update
the 0.6.0 entry header in CHANGELOG.md to include the [**breaking**] tag
(matching the style used in prior entries like 0.3.0) and ensure the bullet
describing "Add per-context system mode support" mentions Config.system_mode so
the breaking change is clearly annotated.
In `@crates/soar-events/CHANGELOG.md`:
- Line 7: Update the changelog entry that currently reads "github asset" to use
the correct capitalization "GitHub asset" so the platform name matches official
branding; locate the entry containing the commit hash 85736a6 (or the line "-
*(download)* Allow regex filter for github asset - ([85736a6](...))") and change
"github" to "GitHub".
In `@crates/soar-operations/CHANGELOG.md`:
- Line 7: Update the CHANGELOG entry string that reads "- *(download)* Allow
regex filter for github asset -
([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b))"
to capitalize the vendor name to "GitHub" (i.e., change "github" to "GitHub");
ensure the same capitalization is used for any matching occurrences in the file
(search for "github" and replace with "GitHub") so the branding is consistent
with other changelogs like crates/soar-events/CHANGELOG.md.
In `@crates/soar-utils/CHANGELOG.md`:
- Around line 2-6: The 0.4.0 changelog entry is missing the required
"[breaking]" marker for the addition of the exhaustive enum variant
UtilsError::Lock; update the 0.4.0 heading or its change list to include
"[breaking]" (for example change "## [0.4.0] ... - 2026-02-21" or add a separate
line like "### [breaking]" under that version) so the changelog follows the
repository convention and clearly flags the breaking change introduced by
UtilsError::Lock.
---
Outside diff comments:
In `@crates/soar-utils/Cargo.toml`:
- Around line 13-21: Move the test-only crate out of production deps: remove the
serial_test entry from the [dependencies] section in Cargo.toml and add the same
serial_test = { workspace = true } entry under [dev-dependencies]; verify
crates/soar-utils/src/path.rs still builds (the #[cfg(test)] module uses
serial_test) and run cargo test to ensure no missing dependency issues.
crates/soar-config/CHANGELOG.md
Outdated
Comment on lines
2
to
6
| ## [0.6.0](https://github.com/pkgforge/soar/compare/soar-config-v0.5.0...soar-config-v0.6.0) - 2026-02-21 | ||
|
|
||
| ### 🚜 Refactor | ||
|
|
||
| - *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) |
Contributor
There was a problem hiding this comment.
Missing [**breaking**] marker on the 0.6.0 entry.
The PR objectives and cargo-semver-checks report that adding the Config.system_mode field to a constructible public struct is a breaking change. The existing convention in this repo (e.g., the 0.3.0 system entry below) uses the [**breaking**] tag for such changes, but it's absent here.
📝 Suggested fix
-## [0.6.0](https://github.com/pkgforge/soar/compare/soar-config-v0.5.0...soar-config-v0.6.0) - 2026-02-21
-
-### 🚜 Refactor
-
-- *(system)* Add per-context system mode support - ([10544ac](…))
+## [0.6.0](https://github.com/pkgforge/soar/compare/soar-config-v0.5.0...soar-config-v0.6.0) - 2026-02-21
+
+### 🚜 Refactor
+
+- *(system)* [**breaking**] Add per-context system mode support - ([10544ac](…))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ## [0.6.0](https://github.com/pkgforge/soar/compare/soar-config-v0.5.0...soar-config-v0.6.0) - 2026-02-21 | |
| ### 🚜 Refactor | |
| - *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) | |
| ## [0.6.0](https://github.com/pkgforge/soar/compare/soar-config-v0.5.0...soar-config-v0.6.0) - 2026-02-21 | |
| ### 🚜 Refactor | |
| - *(system)* [**breaking**] Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-config/CHANGELOG.md` around lines 2 - 6, The 0.6.0 changelog
entry is missing the required [**breaking**] marker for the addition of the
Config.system_mode field; update the 0.6.0 entry header in CHANGELOG.md to
include the [**breaking**] tag (matching the style used in prior entries like
0.3.0) and ensure the bullet describing "Add per-context system mode support"
mentions Config.system_mode so the breaking change is clearly annotated.
| ### ⛰️ Features | ||
|
|
||
| - *(crates)* Add soar-events for frontend-agnostic event reporting ([#156](https://github.com/pkgforge/soar/pull/156)) - ([ea2e72b](https://github.com/pkgforge/soar/commit/ea2e72ba8f56674f16105e22bcc99b6ca6a9d62e)) | ||
| - *(download)* Allow regex filter for github asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b)) |
Contributor
There was a problem hiding this comment.
Capitalize "GitHub" consistently.
The platform name should be "GitHub" (capital H) to match its official branding.
✏️ Proposed fix
-- *(download)* Allow regex filter for github asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b))
+- *(download)* Allow regex filter for GitHub asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - *(download)* Allow regex filter for github asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b)) | |
| - *(download)* Allow regex filter for GitHub asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b)) |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~7-~7: The official name of this software platform is spelled with a capital “H”.
Context: ...) - (download) Allow regex filter for github asset - ([85736a6](https://github.com/p...
(GITHUB)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-events/CHANGELOG.md` at line 7, Update the changelog entry that
currently reads "github asset" to use the correct capitalization "GitHub asset"
so the platform name matches official branding; locate the entry containing the
commit hash 85736a6 (or the line "- *(download)* Allow regex filter for github
asset - ([85736a6](...))") and change "github" to "GitHub".
| ### ⛰️ Features | ||
|
|
||
| - *(crates)* Add soar-operations for frontend-agnostic operations ([#157](https://github.com/pkgforge/soar/pull/157)) - ([932b1e5](https://github.com/pkgforge/soar/commit/932b1e55d6eb3e878115ae9c3ad9cd97ea1f4ebc)) | ||
| - *(download)* Allow regex filter for github asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b)) |
Contributor
There was a problem hiding this comment.
Capitalize "GitHub" consistently.
Same branding issue as in crates/soar-events/CHANGELOG.md — "github" should be "GitHub".
✏️ Proposed fix
-- *(download)* Allow regex filter for github asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b))
+- *(download)* Allow regex filter for GitHub asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - *(download)* Allow regex filter for github asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b)) | |
| - *(download)* Allow regex filter for GitHub asset - ([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b)) |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~7-~7: The official name of this software platform is spelled with a capital “H”.
Context: ...) - (download) Allow regex filter for github asset - ([85736a6](https://github.com/p...
(GITHUB)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-operations/CHANGELOG.md` at line 7, Update the CHANGELOG entry
string that reads "- *(download)* Allow regex filter for github asset -
([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b))"
to capitalize the vendor name to "GitHub" (i.e., change "github" to "GitHub");
ensure the same capitalization is used for any matching occurrences in the file
(search for "github" and replace with "GitHub") so the branding is consistent
with other changelogs like crates/soar-events/CHANGELOG.md.
crates/soar-utils/CHANGELOG.md
Outdated
Comment on lines
2
to
6
| ## [0.4.0](https://github.com/pkgforge/soar/compare/soar-utils-v0.3.0...soar-utils-v0.4.0) - 2026-02-21 | ||
|
|
||
| ### ⛰️ Features | ||
|
|
||
| - *(lock)* Add locking for concurrent process safety ([#154](https://github.com/pkgforge/soar/pull/154)) - ([e3bef6a](https://github.com/pkgforge/soar/commit/e3bef6a09435e83a524b719f7b9f3e0d133c6b64)) |
Contributor
There was a problem hiding this comment.
Missing [**breaking**] marker on the 0.4.0 entry.
cargo-semver-checks reports adding UtilsError::Lock as a breaking change (exhaustive enum variant addition breaks downstream match arms). The entry should follow the established convention.
📝 Suggested fix
-- *(lock)* Add locking for concurrent process safety ([`#154`](…)) - ([e3bef6a](…))
+- *(lock)* [**breaking**] Add locking for concurrent process safety ([`#154`](…)) - ([e3bef6a](…))🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-utils/CHANGELOG.md` around lines 2 - 6, The 0.4.0 changelog entry
is missing the required "[breaking]" marker for the addition of the exhaustive
enum variant UtilsError::Lock; update the 0.4.0 heading or its change list to
include "[breaking]" (for example change "## [0.4.0] ... - 2026-02-21" or add a
separate line like "### [breaking]" under that version) so the changelog follows
the repository convention and clearly flags the breaking change introduced by
UtilsError::Lock.
2443b50 to
dabc2c7
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
crates/soar-utils/Cargo.toml (1)
17-17: Moveserial_testfrom[dependencies]to[dev-dependencies].
serial_testis only used in the#[cfg(test)]module incrates/soar-utils/src/path.rsand should be a dev dependency. Currently, it's unnecessarily included in production builds ofsoar-utilsand its transitive dependencies are pulled into downstream consumers.Suggested fix
Move
serial_testfrom[dependencies]to[dev-dependencies]:[dependencies] blake3 = { workspace = true } miette = { workspace = true } nix = { workspace = true } -serial_test = { workspace = true } thiserror = { workspace = true } [dev-dependencies] +serial_test = { workspace = true } tempfile = { workspace = true }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/soar-utils/Cargo.toml` at line 17, The serial_test crate is declared under [dependencies] but is only used in tests (see #[cfg(test)] in crates/soar-utils/src/path.rs); move the serial_test = { workspace = true } entry from the [dependencies] section of Cargo.toml into the [dev-dependencies] section so it is only pulled in for test builds and not included in production transitive dependencies.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/soar-db/CHANGELOG.md`:
- Around line 8-11: The CHANGELOG entry that mentions "drop recurse_provides" is
a breaking change but lacks the repo's breaking marker; update the bullet on
line containing "*(db)* Add pkg_family, drop recurse_provides" to include the
`[**breaking**]` tag (e.g., "*(db)* [**breaking**] Drop recurse_provides from
Package and NewPackage") so it explicitly calls out removal of the
recurse_provides pub field and dropped struct/columns (references: Package,
NewPackage, recurse_provides).
---
Duplicate comments:
In `@crates/soar-config/CHANGELOG.md`:
- Around line 2-7: Update the 0.6.0 changelog entries to mark breaking changes:
add the `[**breaking**]` tag to the "Add per-context system mode support" entry
(this corresponds to the addition of Config.system_mode to a constructible pub
struct) and also evaluate and add `[**breaking**]` to the "Add soarpkgs, drop
bincache and pkgcache" entry if it changes public APIs; ensure both entries
follow the existing `[**breaking**]` convention used elsewhere in the changelog.
In `@crates/soar-events/CHANGELOG.md`:
- Line 7: Update the changelog entry text that currently reads "Allow regex
filter for github asset" to use the correct branding by replacing "github" with
"GitHub" (i.e., "Allow regex filter for GitHub asset") so the CHANGELOG.md uses
consistent capitalization for "GitHub".
In `@crates/soar-operations/CHANGELOG.md`:
- Line 7: Update the changelog entry text that currently reads "Allow regex
filter for github asset" to use the correct casing "GitHub" (i.e., "Allow regex
filter for GitHub asset"); locate the occurrence in the CHANGELOG entry line
that contains the markdown bullet "*(download)* Allow regex filter for github
asset" and replace "github" with "GitHub", and scan the rest of this file for
any other lowercase "github" occurrences and correct them to "GitHub" for
consistent branding.
---
Nitpick comments:
In `@crates/soar-utils/Cargo.toml`:
- Line 17: The serial_test crate is declared under [dependencies] but is only
used in tests (see #[cfg(test)] in crates/soar-utils/src/path.rs); move the
serial_test = { workspace = true } entry from the [dependencies] section of
Cargo.toml into the [dev-dependencies] section so it is only pulled in for test
builds and not included in production transitive dependencies.
Comment on lines
+8
to
+11
| ### 🚜 Refactor | ||
|
|
||
| - *(db)* Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3)) | ||
| - *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) |
Contributor
There was a problem hiding this comment.
Missing [**breaking**] marker on the "drop recurse_provides" entry.
Per the PR objectives, soar-db 0.5.0 removes the recurse_provides pub field from Package and NewPackage and drops the corresponding struct/columns — a clear breaking change. The repo convention (e.g., line 17: [**breaking**] Remove nest functionality) is to tag these. Line 10 should carry the marker.
📝 Suggested fix
-- *(db)* Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3))
+- *(db)* [**breaking**] Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ### 🚜 Refactor | |
| - *(db)* Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3)) | |
| - *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) | |
| ### 🚜 Refactor | |
| - *(db)* [**breaking**] Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3)) | |
| - *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-db/CHANGELOG.md` around lines 8 - 11, The CHANGELOG entry that
mentions "drop recurse_provides" is a breaking change but lacks the repo's
breaking marker; update the bullet on line containing "*(db)* Add pkg_family,
drop recurse_provides" to include the `[**breaking**]` tag (e.g., "*(db)*
[**breaking**] Drop recurse_provides from Package and NewPackage") so it
explicitly calls out removal of the recurse_provides pub field and dropped
struct/columns (references: Package, NewPackage, recurse_provides).
dabc2c7 to
49b7048
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/soar-package/CHANGELOG.md`:
- Line 10: The changelog entry for the "per-context system mode" refactor is
missing the required [**breaking**] marker; update the bullet "- *(system)* Add
per-context system mode support - ([10544ac]...)" to include the [**breaking**]
tag (matching repo convention) and mention the affected public functions
integrate_appimage and integrate_package so the entry reads as a breaking change
for those APIs.
---
Duplicate comments:
In `@crates/soar-config/CHANGELOG.md`:
- Line 11: Add the missing [**breaking**] marker to the "per-context system
mode" changelog entry: update the line describing "Add per-context system mode
support" to include the [**breaking**] tag (since Config.system_mode was added
to a constructible public struct), referencing Config.system_mode in the entry
so readers understand the breaking change.
In `@crates/soar-db/CHANGELOG.md`:
- Line 15: Update the CHANGELOG entry that currently reads "Add pkg_family, drop
recurse_provides - ([1d97b6d](...))" to mark the removal of the recurse_provides
field as breaking: add the [**breaking**] tag next to the "drop
recurse_provides" item so it clearly signals a breaking change to consumers
(this pertains to the removed pub field recurse_provides on Package/NewPackage
and its schema columns).
In `@crates/soar-events/CHANGELOG.md`:
- Line 7: Update the changelog entry that reads "- *(download)* Allow regex
filter for github asset - ([85736a6]...)" to use the correct branding by
capitalizing "github" to "GitHub" (i.e., change "github asset" → "GitHub asset")
in the line containing the "- *(download)* Allow regex filter for github asset"
entry.
In `@crates/soar-operations/CHANGELOG.md`:
- Line 7: Update the CHANGELOG entry text in crates/soar-operations/CHANGELOG.md
that reads "- *(download)* Allow regex filter for github asset -
([85736a6](...))" to use the correct capitalization "GitHub" (e.g., "Allow regex
filter for GitHub asset"), ensuring consistency with
crates/soar-events/CHANGELOG.md; modify only the string content of that
changelog line.
In `@crates/soar-utils/CHANGELOG.md`:
- Line 6: Update the changelog entry for the locking feature to mark it as a
breaking change: add the `[**breaking**]` tag to the existing entry that
describes the lock addition (the entry mentioning the lock/locking feature and
commit e3bef6a...), because the change introduces the new exhaustive enum
variant `UtilsError::Lock`; edit the line in CHANGELOG.md so the bullet begins
with or includes `[**breaking**]` next to the description.
|
|
||
| ### 🚜 Refactor | ||
|
|
||
| - *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) |
Contributor
There was a problem hiding this comment.
Missing [**breaking**] marker on the "per-context system mode" refactor entry.
Per the PR objectives, soar-package 0.3.0 has a semver-breaking change: public functions integrate_appimage and integrate_package had their parameter counts changed. The per-context system mode refactor at line 10 is that change, yet it has no [**breaking**] tag. The repo convention (e.g., soar-config 0.3.0, soar-utils 0.3.0, soar-db 0.4.0) uses this marker for exactly such cases.
📝 Suggested fix
-- *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a))
+- *(system)* [**breaking**] Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) | |
| - *(system)* [**breaking**] Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-package/CHANGELOG.md` at line 10, The changelog entry for the
"per-context system mode" refactor is missing the required [**breaking**]
marker; update the bullet "- *(system)* Add per-context system mode support -
([10544ac]...)" to include the [**breaking**] tag (matching repo convention) and
mention the affected public functions integrate_appimage and integrate_package
so the entry reads as a breaking change for those APIs.
49b7048 to
93e0336
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/soar-dl/CHANGELOG.md (1)
4-6: Consider documenting removed public symbols under a breaking-changes section.The 0.9.0 release carries several semver-incompatible removals (
ApiKind,fetch_with_fallback,Platform::API_UPSTREAM,Platform::API_PKGFORGE) that the single refactor bullet doesn't surface. Downstream consumers upgrading from 0.8.0 won't know which symbols to stop using or what replaces them.📝 Suggested addition
### 🚜 Refactor - *(download)* Remove proxy api - ([1d3e0ac](https://github.com/pkgforge/soar/commit/1d3e0acc8346834009711cb9f1ad4fbd3454849e)) + +### ⚠️ Breaking Changes + +- Removed pub enum `ApiKind` +- Removed pub function `fetch_with_fallback` +- Removed trait associated constants `Platform::API_UPSTREAM` and `Platform::API_PKGFORGE`; replaced by `Platform::API_BASE`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/soar-dl/CHANGELOG.md` around lines 4 - 6, Add a "Breaking Changes" section to the changelog that explicitly lists the semver-incompatible removals so downstream consumers know what to stop using and what to use instead; specifically mention the removed public symbols ApiKind, fetch_with_fallback, and the constants Platform::API_UPSTREAM and Platform::API_PKGFORGE, state they were removed in 0.9.0, and provide short migration notes or suggested replacements (or link to new APIs) for each symbol.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@crates/soar-events/CHANGELOG.md`:
- Line 7: In the changelog entry "*(download)* Allow regex filter for github
asset -
([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b))"
replace the lowercase "github" with the correctly capitalized "GitHub" so the
line reads "Allow regex filter for GitHub asset" (update the exact text in
CHANGELOG.md).
In `@crates/soar-operations/CHANGELOG.md`:
- Line 7: Update the changelog entry text so the product name is correctly
capitalized: change the phrase "Allow regex filter for github asset" to "Allow
regex filter for GitHub asset" in the changelog line containing the commit
reference ([85736a6] and the text "Allow regex filter for github asset").
In `@crates/soar-utils/CHANGELOG.md`:
- Line 6: Update the changelog entry for the lock feature to mark it as a
breaking change: edit the line describing "Add locking for concurrent process
safety" so it includes the "[breaking]" marker like other breaking entries;
reference the added enum variant UtilsError::Lock in the message to make it
explicit (e.g., "*(lock) [breaking]* Add locking... (adds UtilsError::Lock)"),
following the format used in the 0.3.0 section.
---
Nitpick comments:
In `@crates/soar-dl/CHANGELOG.md`:
- Around line 4-6: Add a "Breaking Changes" section to the changelog that
explicitly lists the semver-incompatible removals so downstream consumers know
what to stop using and what to use instead; specifically mention the removed
public symbols ApiKind, fetch_with_fallback, and the constants
Platform::API_UPSTREAM and Platform::API_PKGFORGE, state they were removed in
0.9.0, and provide short migration notes or suggested replacements (or link to
new APIs) for each symbol.
QaidVoid
force-pushed
the
release-plz-2026-02-16T17-29-19Z
branch
from
93e0336 to
c1ccd61
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/soar-core/CHANGELOG.md`:
- Around line 15-16: The two 0.14.0 changelog lines must be marked as breaking:
update the line mentioning "drop recurse_provides" to include a "[breaking]"
marker because it removes the public field Package::recurse_provides, and update
the line mentioning "per-context system mode" to include a "[breaking]" marker
because it changes the constructor signatures (parameter counts) of
PackageInstaller::new and PackageRemover::new; ensure both entries explicitly
include "[breaking]" in the changelog text.
In `@crates/soar-registry/CHANGELOG.md`:
- Around line 11-12: Add explicit [breaking] markers to the two 0.4.0 changelog
entries: mark the entry that mentions "drop recurse_provides" as breaking
because it removes the public field RemotePackage::recurse_provides, and mark
the entry that mentions "Use inline key string instead of fetching from URL" as
breaking because it removes the public function metadata::fetch_public_key;
update the two lines in CHANGELOG.md to include “[breaking]” in their
descriptions.
---
Duplicate comments:
In `@crates/soar-db/CHANGELOG.md`:
- Line 15: The changelog entry that currently reads "Add pkg_family, drop
recurse_provides ..." must include the [breaking] marker because removal of the
public field recurse_provides from Package and NewPackage is a breaking change;
edit the CHANGELOG.md line to annotate the breaking change (for example add
"[breaking]" adjacent to "drop recurse_provides" or as a prefix for that
sub-item) so the entry clearly marks the removal of the recurse_provides field
from types Package and NewPackage.
In `@crates/soar-events/CHANGELOG.md`:
- Line 7: Update the changelog entry text "Allow regex filter for github asset"
to use the correct branding by capitalizing "GitHub" (i.e., "Allow regex filter
for GitHub asset"); locate the entry containing that phrase (the changelog
bullet referencing commit 85736a6) and replace "github" with "GitHub" while
preserving the rest of the line and markdown formatting.
In `@crates/soar-operations/CHANGELOG.md`:
- Line 7: Update the changelog entry that reads "Allow regex filter for github
asset -
([85736a6](https://github.com/pkgforge/soar/commit/85736a6de8a8cb63aaa7197c5f1cdf8c880e1e5b))"
to capitalize the vendor name as "GitHub" (i.e., change "github" to "GitHub") so
the line reads "Allow regex filter for GitHub asset" while keeping the rest of
the text and the commit reference unchanged.
In `@crates/soar-package/CHANGELOG.md`:
- Line 10: The changelog entry for the per-context system mode refactor (commit
10544ac) is missing the required [**breaking**] marker; update the entry line "-
*(system)* Add per-context system mode support - ([10544ac]...)" to include a
[**breaking**] label (e.g., "- [**breaking**] *(system)* Add per-context system
mode support - ([10544ac]...)") to indicate the parameter-count breaking changes
to integrate_appimage and integrate_package so cargo-semver-checks reflects the
change.
In `@crates/soar-utils/CHANGELOG.md`:
- Line 6: Update the CHANGELOG entry for the lock feature to mark it as
breaking: the line containing "*(lock)* Add locking for concurrent process
safety..." must include a [breaking] marker because adding UtilsError::Lock is a
semver-breaking change; edit that entry to read something like "*(lock)
[breaking]* Add locking for concurrent process safety..." (preserve the rest of
the entry text and links).
Comment on lines
+15
to
+16
| - *(db)* Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3)) | ||
| - *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a)) |
Contributor
There was a problem hiding this comment.
Both 0.14.0 refactor entries are missing [**breaking**] markers.
Per the cargo-semver-checks results in the PR objectives:
- Line 15 (
drop recurse_provides): removes therecurse_providespub field fromPackage— breaking. - Line 16 (
per-context system mode): changes the parameter counts ofPackageInstaller::newandPackageRemover::new— breaking.
📝 Suggested fix
-- *(db)* Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3))
-- *(system)* Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a))
+- *(db)* [**breaking**] Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3))
+- *(system)* [**breaking**] Add per-context system mode support - ([10544ac](https://github.com/pkgforge/soar/commit/10544ac8a2bd896152448f79650c6d98db0d960a))🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-core/CHANGELOG.md` around lines 15 - 16, The two 0.14.0 changelog
lines must be marked as breaking: update the line mentioning "drop
recurse_provides" to include a "[breaking]" marker because it removes the public
field Package::recurse_provides, and update the line mentioning "per-context
system mode" to include a "[breaking]" marker because it changes the constructor
signatures (parameter counts) of PackageInstaller::new and PackageRemover::new;
ensure both entries explicitly include "[breaking]" in the changelog text.
Comment on lines
+11
to
+12
| - *(db)* Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3)) | ||
| - *(pubkey)* Use inline key string instead of fetching from URL - ([f2f3e5c](https://github.com/pkgforge/soar/commit/f2f3e5c1190fd79d18732ea2efb4b668d8130f03)) |
Contributor
There was a problem hiding this comment.
Both 0.4.0 refactor entries are missing [**breaking**] markers.
Per the cargo-semver-checks results in the PR objectives:
- Line 11 (
drop recurse_provides): removes therecurse_providespub field fromRemotePackage— breaking. - Line 12 (
inline key string): removes themetadata::fetch_public_keypub function — breaking.
📝 Suggested fix
-- *(db)* Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3))
-- *(pubkey)* Use inline key string instead of fetching from URL - ([f2f3e5c](https://github.com/pkgforge/soar/commit/f2f3e5c1190fd79d18732ea2efb4b668d8130f03))
+- *(db)* [**breaking**] Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3))
+- *(pubkey)* [**breaking**] Use inline key string instead of fetching from URL - ([f2f3e5c](https://github.com/pkgforge/soar/commit/f2f3e5c1190fd79d18732ea2efb4b668d8130f03))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - *(db)* Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3)) | |
| - *(pubkey)* Use inline key string instead of fetching from URL - ([f2f3e5c](https://github.com/pkgforge/soar/commit/f2f3e5c1190fd79d18732ea2efb4b668d8130f03)) | |
| - *(db)* [**breaking**] Add pkg_family, drop recurse_provides - ([1d97b6d](https://github.com/pkgforge/soar/commit/1d97b6d0f9dc230a306fee936dc6571a0a658be3)) | |
| - *(pubkey)* [**breaking**] Use inline key string instead of fetching from URL - ([f2f3e5c](https://github.com/pkgforge/soar/commit/f2f3e5c1190fd79d18732ea2efb4b668d8130f03)) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-registry/CHANGELOG.md` around lines 11 - 12, Add explicit
[breaking] markers to the two 0.4.0 changelog entries: mark the entry that
mentions "drop recurse_provides" as breaking because it removes the public field
RemotePackage::recurse_provides, and mark the entry that mentions "Use inline
key string instead of fetching from URL" as breaking because it removes the
public function metadata::fetch_public_key; update the two lines in CHANGELOG.md
to include “[breaking]” in their descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 New release
soar-utils: 0.3.0 -> 0.4.0 (⚠ API breaking changes)soar-config: 0.5.0 -> 0.6.0 (⚠ API breaking changes)soar-dl: 0.8.0 -> 0.9.0 (⚠ API breaking changes)soar-registry: 0.3.0 -> 0.4.0 (⚠ API breaking changes)soar-db: 0.4.0 -> 0.5.0 (⚠ API breaking changes)soar-package: 0.2.3 -> 0.3.0 (⚠ API breaking changes)soar-core: 0.13.0 -> 0.14.0 (⚠ API breaking changes)soar-events: 0.0.0 -> 0.0.1 (✓ API compatible changes)soar-operations: 0.0.0 -> 0.0.1 (✓ API compatible changes)soar-cli: 0.11.0 -> 0.11.1⚠
soar-utilsbreaking changes⚠
soar-configbreaking changes⚠
soar-dlbreaking changes⚠
soar-registrybreaking changes⚠
soar-dbbreaking changes⚠
soar-packagebreaking changes⚠
soar-corebreaking changesChangelog
soar-utilssoar-configsoar-dlsoar-registrysoar-dbsoar-packagesoar-coresoar-eventssoar-operationssoar-cliThis PR was generated with release-plz.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Refactor