-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve reports layout #5962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sanne-san
wants to merge
14
commits into
master
Choose a base branch
from
sanne-report-layout-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve reports layout #5962
+936
−522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new `ReportLayout` and `ReportHeader` components to ensure consistent layout across reports - Remove title from report header, and place tabs in the top left corner - Move the details button to the top right corner, rather than the bottom of the report, to reduce vertical space and improve readability. Reduce it to a simple icon with a 'View details' tooltip. - Update the Search terms report to use the new `ReportLayout` and `ReportHeader` components. - Update dashboard to use a simple grid layout, simplifying the html markup and css. - Change 'Screen sizes' title to 'Devices' in the devices report. - Change 'Top pages' title to 'Conversion pages' in the pages report, whenever a conversion goal filter is applied. - Add 'last 30min' pill to the behaviour report when on realtime dashboard, rather than displaying this in the title. - Remove the Combobox input from the custom properties report, and use the same tab dropdown pattern as used for funnels and UTM campaigns.
|
…tes when special goal filter is applied
… goal filter and realtime are active
898b1f4 to
b430b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ReportLayoutandReportHeadercomponents to ensure consistent layout across reportsReportLayoutandReportHeadercomponents.5to10in the tab dropdown.Ultra-wideand(not set)device sizes.Tests
Documentation
Dark mode