Simplify ScreenshotHelper::slugifyUrl()#69
Merged
smnandre merged 1 commit intoplaywright-php:mainfrom Feb 25, 2026
Merged
Conversation
Contributor
Author
|
I'm concerned it might be better to use Symfony String instead of this implementation. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
smnandre
reviewed
Feb 16, 2026
| if (is_string($slug)) { | ||
| $slug = preg_replace('/^www\./', '', $slug); | ||
| } | ||
| $slug = preg_replace('#^(https?://)?(www\.)?#i', '', $url); |
Member
There was a problem hiding this comment.
What about :
Suggested change
| $slug = preg_replace('#^(https?://)?(www\.)?#i', '', $url); | |
| $slug = preg_replace( | |
| ['#^(https?://)?(www\.)?#i', '/[^a-z0-9]+/i'], | |
| ['', '-'], | |
| trim($url) | |
| ); | |
| $slug = strtolower(trim($slug ?? '', '-')); | |
| $slug = substr($slug, 0, $maxLength); | |
| $slug = rtrim($slug, '-'); | |
| return $slug !== '' ? $slug : 'screenshot'; |
Contributor
Author
There was a problem hiding this comment.
Yes it's simpler, but it removes the behaviour with "invalid-url" fallback
smnandre
reviewed
Feb 16, 2026
Member
@stloyd I was going to say "I'd like to minimize the dependencies used here" ... but i'm realizing symfony/string is a dependency of symfony/console so... why not indeed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.